From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo Date: Tue, 21 May 2019 13:30:26 -0300 Message-ID: References: <87h89yqiwu.fsf@gmail.com> <87k1etamhs.fsf@tcd.ie> <875zqcr9sm.fsf@gmail.com> <878sv1gnaf.fsf@tcd.ie> <87ef4r7ucc.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000755dc20589685e90" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="106990"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 18:30:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT7f7-000Rf3-0o for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 18:30:49 +0200 Original-Received: from localhost ([127.0.0.1]:56665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT7f6-0002Nf-2r for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 12:30:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT7ey-0002MR-8X for emacs-devel@gnu.org; Tue, 21 May 2019 12:30:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT7ew-0006P4-VR for emacs-devel@gnu.org; Tue, 21 May 2019 12:30:40 -0400 Original-Received: from mail-it1-x134.google.com ([2607:f8b0:4864:20::134]:50748) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT7ew-0006Nv-R4 for emacs-devel@gnu.org; Tue, 21 May 2019 12:30:38 -0400 Original-Received: by mail-it1-x134.google.com with SMTP id i10so6104515ite.0 for ; Tue, 21 May 2019 09:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/mg/eBGvqW7N3JP64/R6RBR4Ft+mDn9QvKWtPydAJCE=; b=XrTGi8oaZdgj6tel/VWxzrxgkKUcQfbiuOhh7J742qRpJ3y4cbRf4yWjqrdnC+6Ebv Q3wABfEYvArgWGokslqaG1HAbXUEDJ29oi646Lah1X5Vl1FHaFzoU3AruqMMwn3v6GpA FPUdSN4Aq88RexNlbfNInTrJUAxFQKYc9U17VXziceFeSD/oYx2GyPrdSEPxSpaAG7C1 MsvidBgUKwM1/VSLcGJnwHOsgrX1iatVk46xVnfBN3r7UxZXKjilsnmDwchS5ouLfQvT NdnxP4J9ymyhLLNIvgUNTYONs/TMun4fSoSFo+7kc1IM75Ohkm6HTNHJDPDlas1mpv4Z Z/1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/mg/eBGvqW7N3JP64/R6RBR4Ft+mDn9QvKWtPydAJCE=; b=dv1MJfZzujnPCjdJZxi42rs7Z7XG++imu1yQi7e+zbaJm0rteUOKAvgtniUmyY4e2w n7pbUTA8sVfSIpEu2oBNdD4vWzdONOzd7RT3hpVZipWTJ8DhHKC1OZ2sZogmHVE+EpJl ep2JjhrFK5I0usBIc4w+CooSpCvMec/0BdbiyJ1MlqLUGjY98Tex8jYOHVEYYJPh9NGa fxAqWqFghiiwvdNSleJ+Z02TZ3EZD/XbZU54k+Y/at0NLFPrSsfTfcqkWG3m3ptoKczk 5JTN49+yD8Hz//QjyzspikScIMmV93ETYQHRgt1oig98ZMivHlwbYrNxrKHdr8BSWiKx 90ag== X-Gm-Message-State: APjAAAX63D4tdSdBLOg+LaSQ1eUmWRcqSivVKutd/uk9QGHYDLdBwv+N jzFVId1kulczaSLbubjDPrDRuDbi9RkP+M6+cOI= X-Google-Smtp-Source: APXvYqwT+Bkua5CN42x1871Ijr+m/CvVUE0GgABb8sVVrFZJYKO+6M621xbPyE4V8B1aAzcLxICXHEngY6a1j1VtCuI= X-Received: by 2002:a24:6294:: with SMTP id d142mr4624192itc.102.1558456237905; Tue, 21 May 2019 09:30:37 -0700 (PDT) In-Reply-To: <87ef4r7ucc.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::134 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236860 Archived-At: --000000000000755dc20589685e90 Content-Type: text/plain; charset="UTF-8" Looks perfect, thanks. On Tue, 21 May 2019 at 11:31 Basil L. Contovounesios wrote: > Federico Tedin writes: > > > Good catch, sorry about that. The correct header should use "Federico > > Tedin ", like you mentioned. > > No worries. I took the liberties of extending the commit message to > reference this discussion and mention the other variables which were > switched to defvar-local, and shortening the docstring of > tempo-tempo-user-elements-test to more closely follow the conventions in > (info "(elisp) Documentation Tips"), and pushed to master[1]. Let me > know if I messed anything up. > > [1: eb2e9a2ca2]: Use lexical-binding in tempo.el and add tests > 2019-05-21 15:23:23 +0100 > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eb2e9a2ca29f7d5e3b97709e9eca14fa5556ac63 > > Thanks, > > -- > Basil > --000000000000755dc20589685e90 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Looks perfect, thanks.

On Tue, 21 May 2019= at 11:31 Basil L. Contovounesios <co= ntovob@tcd.ie> wrote:
Federi= co Tedin <f= edericotedin@gmail.com> writes:

> Good catch, sorry about that. The correct header should use "Fede= rico
> Tedin <federicotedin@gmail.com>", like you mentioned.

No worries.=C2=A0 I took the liberties of extending the commit message to reference this discussion and mention the other variables which were
switched to defvar-local, and shortening the docstring of
tempo-tempo-user-elements-test to more closely follow the conventions in (info "(elisp) Documentation Tips"), and pushed to master[1].=C2= =A0 Let me
know if I messed anything up.

[1: eb2e9a2ca2]: Use lexical-binding in tempo.el and add tests
=C2=A0 2019-05-21 15:23:23 +0100
=C2=A0 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Deb2e9a2ca29f7d= 5e3b97709e9eca14fa5556ac63

Thanks,

--
Basil
--000000000000755dc20589685e90--