unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Tedin <federicotedin@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 3586fef: Make HIST arg of read-from-minibuffer work with buffer-local vars
Date: Thu, 5 Dec 2019 17:50:48 +0100	[thread overview]
Message-ID: <CAA8GjPmTPS9WLV4xVQPTRFsvLKC3M+3G25gipsOyqK1bwFfbZg@mail.gmail.com> (raw)
In-Reply-To: <jwvfthy6fq2.fsf-monnier+emacs@gnu.org>

> Note that this `add-to-history` call takes place at the very end of
> read_minibuf, hence just *before* we return to previous_buffer.
> Maybe a simpler option than the code above is to postpone the code
> a little bit so that it takes place *after* we return to
> previous_buffer.

Hey Stefan,

Would that mean moving the `add-to-history' call to after the final call
to `unbind_to(count, val)'?

- Fede



  reply	other threads:[~2019-12-05 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191205093041.3243.23144@vcs0.savannah.gnu.org>
     [not found] ` <20191205093043.1A8E0209BE@vcs0.savannah.gnu.org>
2019-12-05 13:56   ` master 3586fef: Make HIST arg of read-from-minibuffer work with buffer-local vars Stefan Monnier
2019-12-05 16:50     ` Federico Tedin [this message]
2019-12-05 19:17       ` Stefan Monnier
2019-12-06  0:36         ` Federico Tedin
2019-12-06  1:57           ` Stefan Monnier
2019-12-09 23:53             ` Federico Tedin
2019-12-10 16:14               ` Stefan Monnier
2019-12-10 18:44                 ` Federico Tedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA8GjPmTPS9WLV4xVQPTRFsvLKC3M+3G25gipsOyqK1bwFfbZg@mail.gmail.com \
    --to=federicotedin@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).