From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo Date: Mon, 20 May 2019 16:32:24 -0300 Message-ID: References: <87h89yqiwu.fsf@gmail.com> <87k1etamhs.fsf@tcd.ie> <875zqcr9sm.fsf@gmail.com> <878sv1gnaf.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="226919"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 21:33:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSo2A-000wtI-Js for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 21:33:18 +0200 Original-Received: from localhost ([127.0.0.1]:40950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSo29-0007pe-1t for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 15:33:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSo1X-0007pK-As for emacs-devel@gnu.org; Mon, 20 May 2019 15:32:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSo1W-00056b-D6 for emacs-devel@gnu.org; Mon, 20 May 2019 15:32:39 -0400 Original-Received: from mail-it1-x133.google.com ([2607:f8b0:4864:20::133]:52923) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSo1W-000564-8Q for emacs-devel@gnu.org; Mon, 20 May 2019 15:32:38 -0400 Original-Received: by mail-it1-x133.google.com with SMTP id t184so948993itf.2 for ; Mon, 20 May 2019 12:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m3kzwBBKi00upzEZ+kDMnP3tHlR8ytGk9qnF4aqBSbM=; b=Xr/hDTUaAxvvQ+4LLre5nEnlw0NXMTRZ7vg0Q+Hmkza0SpEeTUxG6CeRRaooG/wyjf EIzvDimqYdKQRCFuS7AUm6v1YbvIMf2sw77/20/LDTlcAG0RGR5YOxydbAeHScbeZtxF jD2jwPbROW09iD1ghtlV+v8KApgZQq5Dqf2VpBH/vw4pH5GUp+rOzUugKYVc2vN30nPH 5pyI8TsYHXaFgsWMqhmvxPmwiXZ/cSUoPgCS8ZOxHw5yKTeFkBBhgGaU/2awjbBTQFB8 Z4lOq3a7xAoyikMojBqjJIoBs2DcWpJmKpJkgw8G62JidLdwlYq8LPx8+tOo7E7kA4nf WutA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3kzwBBKi00upzEZ+kDMnP3tHlR8ytGk9qnF4aqBSbM=; b=BiIXsW/x+H4WYpmPMkd6V0MoRrek9byec+a5Yi4wJAK6+PwPHC293eIfLnOifgm1b8 fw8KA6nJx/Nun9TBHCsZjxTzuLMKQ4xEc+jXI/vRHzHgARNN6DKH4LrQZvIS8MJk+Mis kNtCjAZILBLZW18JNybQLMtUaxqUbrSxbBbJxIhJIMyMxpwQigQ8oI2T5xwXIHdnYd0I WmesOnBXH2vR+sujoOGVkXM5aQQlnJe+rX2gp1ERTFy4CGDF5zqFDkX+QLIlmxTIhunz ZVe7FQV5jvXK3w+Gf7oTS/W/VtwaiK+MIxYwp+z2oocvmttLTeFhoEKIR8RwY/uoThm1 WlbA== X-Gm-Message-State: APjAAAVklEewpy9ggedt7GXaT7nrXKfUI/K05lmL2Vr3bLmxmu/AoUzi +ffMrNO5cXgnu81SFOpIFvmwD/83vQQa+kv1WqM= X-Google-Smtp-Source: APXvYqxORFAUMZdAD4Vs9RCxOQ40DXFTtbME6cBP/Racj3eJLnNBu1vGvaK6I9Rx18MddzKNxbu0IEK19TgTxJinvkw= X-Received: by 2002:a24:9987:: with SMTP id a129mr601159ite.53.1558380756557; Mon, 20 May 2019 12:32:36 -0700 (PDT) In-Reply-To: <878sv1gnaf.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::133 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236819 Archived-At: Hi Basil, Good catch, sorry about that. The correct header should use "Federico Tedin ", like you mentioned. Thanks! On Mon, May 20, 2019 at 12:26 PM Basil L. Contovounesios wrote: > > Federico Tedin writes: > > > Hi Basil, thanks for taking the time to review the patch. I've fixed the > > mistakes using the suggestions you made. I've also added the 'abbrev' tag > > to tempo.el. > > Thanks, looks fine to me. > > > From dad0f0a6841e321cfca4c2962e3ce384199ff51e Mon Sep 17 00:00:00 2001 > > From: federicotdn > > Date: Tue, 14 May 2019 09:16:00 -0300 > > Subject: [PATCH 1/1] Use lexical-binding in tempo.el and add tests > > I was about to push your patch when I noticed its From: header lists a > different name and email address from that of your email and other Emacs > contributions. Is it okay to amend the patch to use the latter? > > Thanks, > > -- > Basil