unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Tedin <federicotedin@gmail.com>
To: monnier@iro.umontreal.ca
Cc: martin rudalics <rudalics@gmx.at>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode
Date: Mon, 29 Oct 2018 20:40:18 -0300	[thread overview]
Message-ID: <CAA8GjP=h1Z8GZ8HoUWXmADfn0wM9aKZAgqRPdEsBMn2EMf8WfQ@mail.gmail.com> (raw)
In-Reply-To: <jwvtvl6ewxv.fsf-monnier+emacsdiffs@gnu.org>

> We don't want the code to list the finite set of known region types, I think.
>
> We could try and make it a cl-defgeneric, but we need something on which
> to dispatch.

Right, to use cl-defgeneric, the region would need to be represented
with different types of objects depending on the region type (from
what I understand about the mechanics of cl-defgeneric).

If we implemented the `reactivate-mark-function` variable instead (and
the function `reactivate-mark`), would it be OK to have code like
this?

(pcase reactivate-mark-function
  ('normal-reactivate-mark-function ...)
  ('rectangle-reactivate-mark-function ...))

I can imagine using something like that in mouse-drag-and-drop-region,
when deciding how to calculate if the drag was negligible.



  reply	other threads:[~2018-10-29 23:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181017063829.3775.67018@vcs0.savannah.gnu.org>
     [not found] ` <20181017063831.03DCB2044D@vcs0.savannah.gnu.org>
2018-10-17 15:47   ` [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Stefan Monnier
2018-10-17 16:17     ` Drew Adams
2018-10-19 15:24       ` Stefan Monnier
2018-10-20  3:21         ` Federico Tedin
2018-10-20  3:48           ` Stefan Monnier
2018-10-20 20:21             ` Federico Tedin
2018-10-20 20:56               ` Federico Tedin
2018-10-20 21:21               ` Stefan Monnier
2018-10-21  8:22                 ` martin rudalics
2018-10-22 13:04                   ` Federico Tedin
2018-10-25 23:24                     ` Federico Tedin
2018-10-26 17:25                       ` Stefan Monnier
2018-10-26 22:07                         ` Federico Tedin
2018-10-28  0:30                           ` Stefan Monnier
2018-10-29 23:40                             ` Federico Tedin [this message]
2018-10-30 12:52                               ` Stefan Monnier
2019-01-07 17:40                               ` Stefan Monnier
2019-01-26 21:58                                 ` Federico Tedin
2019-01-28  9:12                                   ` Stefan Monnier
2019-01-29  4:02                                     ` Federico Tedin
2019-01-29  9:28                                       ` Stefan Monnier
2019-01-30  3:39                                         ` Federico Tedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA8GjP=h1Z8GZ8HoUWXmADfn0wM9aKZAgqRPdEsBMn2EMf8WfQ@mail.gmail.com' \
    --to=federicotedin@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).