From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg Date: Tue, 4 Jun 2019 11:00:28 +0200 Message-ID: References: <20190603135626.32064.50250@vcs0.savannah.gnu.org> <20190603135628.1D13220AD1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="19535"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 11:01:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hY5K1-0004xk-6L for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 11:01:33 +0200 Original-Received: from localhost ([127.0.0.1]:48966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY5K0-0001dT-97 for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 05:01:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY5JH-0001d5-KD for emacs-devel@gnu.org; Tue, 04 Jun 2019 05:00:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hY5JG-0006EQ-CA for emacs-devel@gnu.org; Tue, 04 Jun 2019 05:00:47 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:41440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hY5JG-00068k-47 for emacs-devel@gnu.org; Tue, 04 Jun 2019 05:00:46 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id x25so18728768eds.8 for ; Tue, 04 Jun 2019 02:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5q25KVY98M2xznOdoesmdJuw0kf0vQbXgx9UPZtn4nA=; b=ZV6MWIzjp8mptkdK3WmVWjb/ErM59McefwbTvtp3UbmIBYLjHSSesmbajII0HRcUxV rpVxKRrVXqGE20CvTiuLcF6ZBGz+NrNMK44LmOI+mPFIzufBF+t8G9hy/BVYhEhTXNmr 3R7cl6rS5W/WmJ7qasRJwcOaTQJbDhHvdVI0av0YbZ4JjD6XWTl9C/Xgr3+T5vG7Hhzt nX6gSeqbRPg2VmhBAzkkxRO4MrmasfY2/gX5CnTX+d53s7bdaQcBx5DAWYjkHQb/TztW qPITN8Tr8ukxdAZ9IDN8EpAxrSVdT8WtTchwUCuG6O+euyfLkHVZe0FpOTihSQbGwalc 4Pmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5q25KVY98M2xznOdoesmdJuw0kf0vQbXgx9UPZtn4nA=; b=rFItu2F19S8DLcNDznNf2SNvRXJhSnfc7kBq4L9ZBcGdZZa0mDF2kY4eURIFE9DKeJ eJYnmAoepuaP9cgnxfPn4HfMaSQgpQjj10PgCCmTHLGYMIl8o4qZ+PYJ72EA4poLKiEu Jfurqk5qYF4EgRy8v53AKIYKFi9FHrf/VDz0iUEuMNu4jkhoLXxi+ECq8ECmYloEi+WC 3nYhk6PTb3IXamvIJzPp2OQIVob6KLpfoWin5HdIjqmjQVaKwFJLtHhMyxgsTdFtrAsh gdO05ACPHlbjpF8qiqb6+1DKRGkuHKBEP2jW9YMTwNoE/jIeRF64Y3Yj7BXGl8d0Mhu6 F6uQ== X-Gm-Message-State: APjAAAXFodGrH7TkWw5rgrsE7jUpBfcF/jMqNDDHH0q2mmweCBnuco37 R7p9IYCSsZe2bjWjgxYxO40n4rJf6up/z3s/3W4zhEAX X-Google-Smtp-Source: APXvYqz8peKOp4nZtxD6gtNxA5o2QpoPDx407ovscgbazKQ5Ykm2ZdkOIOHkmOsWC26zVDX+YMAiZ3YJan9mb7rg0EI= X-Received: by 2002:a50:c908:: with SMTP id o8mr5197025edh.131.1559638838748; Tue, 04 Jun 2019 02:00:38 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237243 Archived-At: > > the message seding is handled by an external program, so no Unicode > > encoding is performed in Emacs. Thus Emacs must not assert that the > > Unicode encoding was performed. > > Not sure what this has to do with Unicode. It seems to just be about > encoding or not encoding: whether encoding is done with one of the > Unicode coding-systems (e.g. utf-8) or something else (e.g. latin-1) > doesn't seem to make a difference. > > Or am I missing something? I'm sending an SMIME-encoded message using openssl. This requires to keep the plain text non-encoded. There's already existing message.el code that sets `message-inhibit-body-encoding' to t. But if the encoding is inhibited, we should not assert if Unicode was not encoded. Thanks to this patch I can now send SMIME-encoded email that has e.g. German umlauts in it. I found the existing support for sending SMIME-encoded email lacking. For a while, some mail clients would detect the sent email as signed, but others not. I can contribute the openssl signing code that works for me now if there's interest. regards, Oleh