* Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg
[not found] ` <20190603135628.1D13220AD1@vcs0.savannah.gnu.org>
@ 2019-06-03 17:16 ` Stefan Monnier
2019-06-04 9:00 ` Oleh Krehel
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2019-06-03 17:16 UTC (permalink / raw
To: Oleh Krehel; +Cc: emacs-devel
> the message seding is handled by an external program, so no Unicode
> encoding is performed in Emacs. Thus Emacs must not assert that the
> Unicode encoding was performed.
Not sure what this has to do with Unicode. It seems to just be about
encoding or not encoding: whether encoding is done with one of the
Unicode coding-systems (e.g. utf-8) or something else (e.g. latin-1)
doesn't seem to make a difference.
Or am I missing something?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg
2019-06-03 17:16 ` [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg Stefan Monnier
@ 2019-06-04 9:00 ` Oleh Krehel
2019-06-04 13:15 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Oleh Krehel @ 2019-06-04 9:00 UTC (permalink / raw
To: Stefan Monnier; +Cc: emacs-devel
> > the message seding is handled by an external program, so no Unicode
> > encoding is performed in Emacs. Thus Emacs must not assert that the
> > Unicode encoding was performed.
>
> Not sure what this has to do with Unicode. It seems to just be about
> encoding or not encoding: whether encoding is done with one of the
> Unicode coding-systems (e.g. utf-8) or something else (e.g. latin-1)
> doesn't seem to make a difference.
>
> Or am I missing something?
I'm sending an SMIME-encoded message using openssl. This requires to
keep the plain text non-encoded.
There's already existing message.el code that sets
`message-inhibit-body-encoding' to t. But if the encoding is
inhibited, we should not assert if Unicode was not encoded. Thanks to
this patch I can now send SMIME-encoded email that has e.g. German
umlauts in it.
I found the existing support for sending SMIME-encoded email lacking.
For a while, some mail clients would detect the sent email as signed,
but others not. I can contribute the openssl signing code that works
for me now if there's interest.
regards,
Oleh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg
2019-06-04 9:00 ` Oleh Krehel
@ 2019-06-04 13:15 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2019-06-04 13:15 UTC (permalink / raw
To: Oleh Krehel; +Cc: emacs-devel
> There's already existing message.el code that sets
> `message-inhibit-body-encoding' to t. But if the encoding is
> inhibited, we should not assert if Unicode was not encoded.
So from your description I think indeed this has nothing to do with
Unicode: the code you changed doesn't "assert if Unicode was not
encoded". It asserts that the text was not encoded. Unicode or
anything else. German umlauts are chars that indeed appear in the
Unicode charset, but they also appear in many other charsets (such as
latin1).
"Encoding" turns chars into bytes and the test verifies that there are
only bytes left.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-04 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190603135626.32064.50250@vcs0.savannah.gnu.org>
[not found] ` <20190603135628.1D13220AD1@vcs0.savannah.gnu.org>
2019-06-03 17:16 ` [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg Stefan Monnier
2019-06-04 9:00 ` Oleh Krehel
2019-06-04 13:15 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).