From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Wed, 16 Nov 2022 00:34:04 -0800 Message-ID: References: <6C8B0F8E-DF61-4BC3-B0D0-56DBB66BE637@gmail.com> <7AE71CCA-6F18-4DE6-8608-7D9B3E9E52FB@gmail.com> <9BA853EA-8B7F-41A0-A174-D86DF5CE7788@gmail.com> <83sfj3cfl0.fsf@gnu.org> <03309451-1AEB-458C-88FD-9715CECC27A2@gmail.com> <83mt9bc9ke.fsf@gnu.org> <8335b19ndr.fsf@gnu.org> <39ECD413-BD10-4BF3-90AC-36F02276607E@gmail.com> <8A2361BB-1081-4550-AC29-B9E99BFC2FB8@gmail.com> <42DBD4F5-71D9-434E-B7B4-4E0FF89F934F@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8061"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: =?utf-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 16 09:35:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovDsx-0001qp-Js for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Nov 2022 09:35:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovDs5-00024H-1e; Wed, 16 Nov 2022 03:34:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovDs2-000247-Uo for emacs-devel@gnu.org; Wed, 16 Nov 2022 03:34:10 -0500 Original-Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovDs1-0008S1-EM; Wed, 16 Nov 2022 03:34:10 -0500 Original-Received: by mail-pl1-x631.google.com with SMTP id p12so15783798plq.4; Wed, 16 Nov 2022 00:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2gu+C+XvwnuYNfwkNXqvPBcMnk2PNpBj111MnOGlQmU=; b=PFfgp/H2tM9CU3DzexPADXKBbCeDMtGYffSp7DJZv8uEoa9ZAYB1hwS7n74Pq+QKzd jOAdcWcD9jFjEHiS6w3c0zwSeQ/7krEwC0BHpaocxu/wTLO5xNfbGRXoo6jWxnPHLcRL IqjkiHu4pjokEjTMsR2g3z3prFi3mEMA5xLc9jz6W8LhxJIQg/xwk+o+hDkt199ROrpg o6b/YLcMlKDGHFpIYlcn33ZTrdkrtrW9P0++/vkzNf8GJEiH0uXiXGugXKQizz4w+IU+ WQDIPR+2Rpl4UQLPnHvjj7poE2z4uzdYBYi7QffmsSXhsKnaLoV3/KZOIERYG4rcVxg6 vMhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gu+C+XvwnuYNfwkNXqvPBcMnk2PNpBj111MnOGlQmU=; b=z6gDdZvEE0lUNAhrWP8ogY4fjXzhaYI8sJUXTtIbCFRoNL51SdyRm+BAORyHTzhTy7 AWjAe5vDc3UnIhMUVlwZv8U80VnKd3pqgOWJhCLYJC0FKVylOWHDiikiYxl8Lc0SFGYj ZsSIs2uikBNr27E71xlUzC+VTp3zO0W2By32zRy4s60u40l38bQairXXihcJUlJqMKVQ ZPm07t9L+zg3fg42t/QNCJgNNRU5WqO4HGefUSuYZTVVNyUH1b46haaEyIgJA5bpF6ZC 23+xnMSL0X7Qr57mc89pUV7TIUbc9iwcN/ftDLbYyS87M5Krs9eOXT7CE7ccm1xbkzSD HdtQ== X-Gm-Message-State: ANoB5pkBDHBimPjse3PzPdiQgnumizEtZJxg/RjaAuz5eaUn5oS2hRQd bK66jLJAK3Rd/RecZ4NArwICUVzTJT0= X-Google-Smtp-Source: AA0mqf6HdW/jjLLfdH6ird3bZp0BDo6Un5LCwFLRgAk5Ue4dwvwv1iguKyQGkeGjXAFLNRpzqpIDRQ== X-Received: by 2002:a17:902:ce8b:b0:186:a3a0:601c with SMTP id f11-20020a170902ce8b00b00186a3a0601cmr7897582plg.105.1668587647626; Wed, 16 Nov 2022 00:34:07 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a27-20020a630b5b000000b00460ea630c1bsm8971764pgl.46.2022.11.16.00.34.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2022 00:34:06 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=casouri@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299910 Archived-At: > On Nov 12, 2022, at 3:57 PM, Jo=C3=A3o Paulo Labegalini de Carvalho = wrote: >=20 > Thanks, Yuan for the feedback and explanation. >=20 > I am attaching the patch with the corrections pointed out by you. >=20 > In here >=20 > +This is used instead of `font-lock-builtion-face' directly because > +otherwise the whole command, including the variable assignment part, > +is fontified with with `font-lock-builtin-face'. An alternative to > +this would be to declaration_command nodes to have a `name:' = field.=E2=80=9D >=20 > I guess you meant =E2=80=9C...for declaration_command node to = have=E2=80=A6=E2=80=9D? (Declaimer: not native speaker) >=20 > You are right about the plural in nodes, as I was referring to a = "class" of commands. But I think "to" is the correct preposition. Thus I = changed the sentence to: An alternative to this would be to = declaration_commands to have a `name:' field. >=20 > Let me know what you think and if something else looks off. I forgot about one thing in the last message (sorry!): +(provide 'sh-mode) +;;; sh-mode.el ends here Is there any particular reason why you changed sh-script to sh-mode? Yuan