* finalizers and dynamic modules
@ 2016-02-15 21:41 Jess Balint
2016-02-18 19:25 ` John Wiegley
0 siblings, 1 reply; 2+ messages in thread
From: Jess Balint @ 2016-02-15 21:41 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
Hi!
Dynamic modules are really cool so far, but I think finalizers should not
be mandatory (alloc.c):
#ifdef HAVE_MODULES
else if (mblk->markers[i].m.u_any.type == Lisp_Misc_User_Ptr)
{
struct Lisp_User_Ptr *uptr = &mblk->markers[i].m.u_user_ptr;
uptr->finalizer (uptr->p); <----- should NULL-check first
}
#endif
https://github.com/emacs-mirror/emacs/blob/master/src/alloc.c#L6893
thanks.
Jess
[-- Attachment #2: Type: text/html, Size: 972 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: finalizers and dynamic modules
2016-02-15 21:41 finalizers and dynamic modules Jess Balint
@ 2016-02-18 19:25 ` John Wiegley
0 siblings, 0 replies; 2+ messages in thread
From: John Wiegley @ 2016-02-18 19:25 UTC (permalink / raw)
To: Jess Balint; +Cc: emacs-devel
>>>>> Jess Balint <jbalint@gmail.com> writes:
> Dynamic modules are really cool so far, but I think finalizers should not be
> mandatory (alloc.c):
Hi Jess, can you resend this using M-x report-emacs-bug, so that we can
properly track the issue? Anything sent to emacs-devel of a substantive
nature runs the risk of being forgotten.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-18 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 21:41 finalizers and dynamic modules Jess Balint
2016-02-18 19:25 ` John Wiegley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).