From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?J=E9r=E9my_Compostella?= Newsgroups: gmane.emacs.devel Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to support a prefix argument following suggesion by Juri Linkov Date: Thu, 26 Jan 2012 20:28:02 +0100 Message-ID: References: <87lioufh0t.fsf@thinkpad.tsdh.de> <871uqmffee.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d044471a32d2e2004b77362c9 X-Trace: dough.gmane.org 1327606132 11597 80.91.229.12 (26 Jan 2012 19:28:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 26 Jan 2012 19:28:52 +0000 (UTC) Cc: 10614@debbugs.gnu.org, Gideon Stupp , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 26 20:28:46 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from [140.186.70.17] (helo=lists.gnu.org) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RqV02-000874-5w for ged-emacs-devel@m.gmane.org; Thu, 26 Jan 2012 20:28:46 +0100 Original-Received: from localhost ([::1]:35279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqUzp-0002Bi-5e for ged-emacs-devel@m.gmane.org; Thu, 26 Jan 2012 14:28:33 -0500 Original-Received: from [140.186.70.92] (port=54709 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqUzm-0002AH-EC for emacs-devel@gnu.org; Thu, 26 Jan 2012 14:28:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqUzh-0003um-Di for emacs-devel@gnu.org; Thu, 26 Jan 2012 14:28:26 -0500 Original-Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:60293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqUzh-0003ui-Ab for emacs-devel@gnu.org; Thu, 26 Jan 2012 14:28:25 -0500 Original-Received: by obbta7 with SMTP id ta7so1164918obb.0 for ; Thu, 26 Jan 2012 11:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=t/qXnR9UhlM6SWOG1s97U6iZdRGQ051hKTvULli7okk=; b=xlM01bqIAas6ZjbNL+RVsAmbn+HF+mbVdBfAMibGnaockMisrxTMi6aYnGilR4BynH ZFibBn9XdRz9Q6aaAiOuXirw1r+hQGsifwZv7IZK+eWikw8juTQ73+KMfJlVbo0Xxucj ECpNc8HTSgN1c1/xwBbDEAFe5jxxsnwavZBNY= Original-Received: by 10.182.74.102 with SMTP id s6mr3565868obv.46.1327606103092; Thu, 26 Jan 2012 11:28:23 -0800 (PST) Original-Received: by 10.60.50.37 with HTTP; Thu, 26 Jan 2012 11:28:02 -0800 (PST) In-Reply-To: <871uqmffee.fsf@thinkpad.tsdh.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147954 Archived-At: --f46d044471a32d2e2004b77362c9 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2012/1/26 Tassilo Horn > Tassilo Horn writes: > > > But how the heck is the usage of the prefix arg supposed to work? > > When I do C-s foo C-3, isearch is exited... > > That was my fault. Of course, loading the patched isearch.el didn't > make the changed isearch-mode-map active (defvar). It works fine, now. > > Usability-wise, C-s foo C- C-s makes only sense if that > keystroke is shorter to type than C-s multiple times. So maybe the > numbering should start with some offset, say, with the 5th next match? > > And the typing of C-s after the number is a bit inconvenient, so maybe, > C-7 could jump directly to the match hinted with 7, and only for > two-digit matches C-s was needed, i.e., C-u 1 2 C-s to jump to the 12th > match? > > I just played play with it too and I really like it. Here my notes: - I do agree with Tassilo, C-7 should directly jump to match hinted 7. - When more than lazy-highlight-max-at-a-time are visible in the window, the prefix number is restarted from 1 on the next match hinted. It's confusing and I think it should not appear on these items. - A defcustom variable should be added to enable/disable the match hinted prefix number. Anyway, it's an very interesting improvement. J=E9r=E9my --f46d044471a32d2e2004b77362c9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
2012/1/26 Tassilo Horn <tassilo@member.fsf.org>
Tassilo Horn <tassilo@member.fsf.org> writes:

> But how the heck is the usage of the prefix arg supposed to work?
> When I do C-s foo C-3, isearch is exited...

That was my fault. =A0Of course, loading the patched isearch.el didn&= #39;t
make the changed isearch-mode-map active (defvar). =A0It works fine, now.
Usability-wise, C-s foo C-<number> C-s makes only sense if that
keystroke is shorter to type than C-s multiple times. =A0So maybe the
numbering should start with some offset, say, with the 5th next match?

And the typing of C-s after the number is a bit inconvenient, so maybe,
C-7 could jump directly to the match hinted with 7, and only for
two-digit matches C-s was needed, i.e., C-u 1 2 C-s to jump to the 12th
match?


I just played play with it too and I r= eally like it. Here my notes:
- I do agree with Tassilo, C-7 shou= ld directly jump to match hinted 7.
- When more than=A0lazy-highl= ight-max-at-a-time are visible in the window,
=A0=A0the prefix number is restarted from 1 on the next match hinted. = It's confusing
=A0=A0and I think it should not appear on thes= e items.
- A defcustom variable should be added to enable/disable= the match hinted prefix
=A0=A0number.

Anyway, it's an very=A0inte= resting=A0improvement.

J=E9r=E9my

--f46d044471a32d2e2004b77362c9--