From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] feature/byte-switch 086c4ea: * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch Date: Wed, 18 Jan 2017 23:49:50 +0530 Message-ID: References: <20170118171311.10996.72260@vcs.savannah.gnu.org> <20170118171311.A84EA220125@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045f719a6ebb840546627630 X-Trace: blaine.gmane.org 1484764913 13303 195.159.176.226 (18 Jan 2017 18:41:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jan 2017 18:41:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 18 19:41:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTvB5-0002uv-Fp for ged-emacs-devel@m.gmane.org; Wed, 18 Jan 2017 19:41:47 +0100 Original-Received: from localhost ([::1]:43567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTvBA-0005Fc-6s for ged-emacs-devel@m.gmane.org; Wed, 18 Jan 2017 13:41:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTupu-0005iH-IF for emacs-devel@gnu.org; Wed, 18 Jan 2017 13:19:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTupt-0000c7-O7 for emacs-devel@gnu.org; Wed, 18 Jan 2017 13:19:54 -0500 Original-Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]:34195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cTupt-0000bw-In for emacs-devel@gnu.org; Wed, 18 Jan 2017 13:19:53 -0500 Original-Received: by mail-yw0-x234.google.com with SMTP id w75so14293779ywg.1 for ; Wed, 18 Jan 2017 10:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nhHYfHf7Vq5VQ5XGOhgOqugA4Etfv9LNLT7jx1sOu7Y=; b=SvBd456GAEUr9uozbHXU5n1NPhx9zGDeQSEPYk1c8CbvBO/QIsCRr7c7EkWdg+xlBy GdIZ3tvB9hFIv1dcu1O6oC4T4Jr55OOMW3bKK415vDPTmZFxuMVDI8byamr+PTAhcTIE uAB9qlTuOPDIdl2nWi34IXd1H+W3bm/BeHe/QipV3TplcrF1MfNfcuRe+5ejdrotV9/P 4oIElvOq0zxIBCtUYFPx92OGCB9BGspo7QEQPqIw9avhwo/WSkALMOmwbxAuBldq9cNz l9bWPxEycF4JSqkMIoO5QQG1+tEDO7xTd5KmFOKXOC97FAj4CXsZSbPGjPUg9LgJD9xD vdZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nhHYfHf7Vq5VQ5XGOhgOqugA4Etfv9LNLT7jx1sOu7Y=; b=JQ+4CoNPdMMbKqzpj8rctHKaEAnyw1OZLwT6ePzWsmNX6FW8MQbgdjPKMi46m48IsA Q0ktFcWnmkn3LgETZWJ1/4wkcJCtxppma6RMOoTv9tgvAk6hNH898P4ugVy/a1FkGuYr 8WdbjkAf/3pUuOXRHu4oxDFyMTvWVg58mqUWgWtaJvKq1iRpJ5kwoI9vQY5UQXp+wMIq DbXpiBcXqBmmnXvIfeG5bA6baW6MLqaRz9+rvWEFR8JNf9bIz0BYqjffHcXdFNirwwi0 pMZb0NFIV6JMevX+Uuvxgp7xF7hiPkjq/xNeT+OYyiuY1tfwmGsku1KUW1rg5hRDB8Yt +h6Q== X-Gm-Message-State: AIkVDXIA0IBRji8znYuJ7iC9DeC3FedFalnzrnXGR7y2twD4HEkdd9xuHxFPQVEoboS3h3RCnCwtwtOTn8kXOA== X-Received: by 10.129.174.90 with SMTP id g26mr3931584ywk.25.1484763591259; Wed, 18 Jan 2017 10:19:51 -0800 (PST) Original-Received: by 10.129.153.77 with HTTP; Wed, 18 Jan 2017 10:19:50 -0800 (PST) Original-Received: by 10.129.153.77 with HTTP; Wed, 18 Jan 2017 10:19:50 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211383 Archived-At: --f403045f719a6ebb840546627630 Content-Type: text/plain; charset=UTF-8 Will push a fix soon, thanks. On 18 Jan 2017 11:18 p.m., "Stefan Monnier" wrote: > > * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch > > Fgethash type checks the provided table object, which is unnecessary > > for compiled bytecode. > > While it's true that we can cause a core dump of Emacs if we feed it an > invalid .elc file, that's a "feature" I'd rather shrink rather > than generalize. > > > Stefan > --f403045f719a6ebb840546627630 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Will push a fix soon, thanks.

On 18 Jan 2017 11:18 p.m., "Stefan= Monnier" <monnier@iro.= umontreal.ca> wrote:
>=C2=A0 =C2=A0 =C2=A0* src/bytecode.c: (exec_byte_code) Use hash= _lookup for Bswitch
>=C2=A0 =C2=A0 =C2=A0Fgethash type checks the provided table object, whi= ch is unnecessary
>=C2=A0 =C2=A0 =C2=A0for compiled bytecode.

While it's true that we can cause a core dump of Emacs if we feed it an=
invalid .elc file, that's a "feature" I'd rather shrink r= ather
than generalize.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan
--f403045f719a6ebb840546627630--