From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] feature/byte-switch 13eabbd: bytecode.c (exec_byte_code): Use h->count instead of HASH_TABLE_SIZE Date: Thu, 9 Feb 2017 21:57:25 +0530 Message-ID: References: <20170209134357.2270.49861@vcs0.savannah.gnu.org> <20170209134357.C161E25FF6@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c07d0b4e8785e05481b74b1 X-Trace: blaine.gmane.org 1486657736 9508 195.159.176.226 (9 Feb 2017 16:28:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Feb 2017 16:28:56 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 09 17:28:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbraU-0002Dl-HU for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2017 17:28:50 +0100 Original-Received: from localhost ([::1]:38820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbraa-00050a-Ab for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2017 11:28:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbrZB-0003RI-8N for emacs-devel@gnu.org; Thu, 09 Feb 2017 11:27:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbrZA-0004Q0-CF for emacs-devel@gnu.org; Thu, 09 Feb 2017 11:27:29 -0500 Original-Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:34675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbrZA-0004PV-9H for emacs-devel@gnu.org; Thu, 09 Feb 2017 11:27:28 -0500 Original-Received: by mail-yw0-x231.google.com with SMTP id w75so5269918ywg.1 for ; Thu, 09 Feb 2017 08:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sJMOVKiGKz9n+v+uguj2XKD8gJjL6YJswh5i8/wLCg4=; b=bHV58+7GU57/eadMQPUlykAA1LOpmGAopxZ6ZBxItPfFlMXzx9wxMAT/zE0BmZ49HT UiP4tptkdbAeoUfIY687fvudBmbPjRdMyFO4vBbd0mgj0HfMs8Mysgg9gTYV5c/q+MZ9 3Qw8o77MN6+0wD3hvnONm3JEtJnrA60RlawHPLUITdP2YGCVfCU+ijpHC5CVT5t1jgiq l9cb952KGQ5i36i4q0v2p8GRkdnrLwskEA1uRfqtM3TGMh6UZtBPYYy3pvN7K1qtsyM4 x+GcNUZCqOqyZPcBWwOEtlMk13qWDhLFjPqvbF/oTyNYAcLIeClTRUqcZ05GSiDLj5b2 lOLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sJMOVKiGKz9n+v+uguj2XKD8gJjL6YJswh5i8/wLCg4=; b=Lr0DLcMwT4QvxXQ53Es8dCNZqA63CXsZt+IXWltcVffSpsEznAjlL3wceD2f4lEOwO ffPeD/HiLu4tH3MTIckX6gcU1QXbzmQD7rLIKoPvPyfVJ4ByXUk54Gc5QT8M2laQbjuP TJl2VLH9bNiIfUxVfxTDZxcJhOixiqLtIRwX9jr6NBgT+K/Etd57S6yU2THv6KpzVEhY D0b4zkJj2DQIamAEupi+kn7HStImf19lml/V95NW4O72/mAgNzqIszhZhYzz9qbIWbci CYg10zFu90dTrpbSj4xWoBCWnkF+u/LHW/k4iiBtbxMEJofqe1DJrkvcFXV8bpKX7Pf0 uoJg== X-Gm-Message-State: AMke39l6vXxpmXzNNMF5TXWn5h49F+W25wMhO8f8KZoOfnJM7E79ag5vrE1ZAc38hG3GNgZw1m9fMCsm6lxlhw== X-Received: by 10.13.224.4 with SMTP id j4mr3116989ywe.139.1486657646258; Thu, 09 Feb 2017 08:27:26 -0800 (PST) Original-Received: by 10.129.153.77 with HTTP; Thu, 9 Feb 2017 08:27:25 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212170 Archived-At: --94eb2c07d0b4e8785e05481b74b1 Content-Type: text/plain; charset=UTF-8 On Thursday, February 9, 2017, Stefan Monnier wrote: > > +#ifdef BYTE_CODE_SAFE > > + /* Hash tables for switch are declared with :size set to > exact > > + number of cases, so this should always be true. */ > > + eassert (HASH_TABLE_SIZE (h) == h->count); > > +#endif > > This equality is not needed for safety, only for performance. > IOW you can drop the assert altogether and turn it into a comment. > Done, thanks. -- Vibhav Pant vibhavp@gmail.com --94eb2c07d0b4e8785e05481b74b1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thursday, February 9, 2017, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> +#ifdef BYTE_CODE_SAFE
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Hash tables for switch a= re declared with :size set to exact
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0number of case= s, so this should always be true.=C2=A0 */
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 eassert (HASH_TABLE_SIZE (h= ) =3D=3D h->count);
> +#endif

This equality is not needed for safety, only for performance.
IOW you can drop the assert altogether and turn it into a comment.

Done, thanks.=C2=A0


--
Vibhav = Pant
vibhavp@gmai= l.com
--94eb2c07d0b4e8785e05481b74b1--