From: Vibhav Pant <vibhavp@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Critical bytecode bug with hash tables while dumping emacs.
Date: Fri, 27 Jan 2017 00:27:27 +0530 [thread overview]
Message-ID: <CA+T2Sh2fD7x9F4n+euwRkuCWWhCw2_mvsTjeeoTS91kMLHYMkQ@mail.gmail.com> (raw)
In-Reply-To: <66c98f41-e9b3-2aa7-a2a2-4595dd4ee653@cs.ucla.edu>
On Thu, Jan 26, 2017 at 11:03 PM, Paul Eggert <eggert@cs.ucla.edu> wrote:
> In that case the bug is not critical, right? One way to address the problem
> is to say that code should not print hash tables before dumping.
It's critical in the sense that any code loaded from loadup.el is effectively
prohibited from using printed hash tables in any way. I've recently been
working on adding a new 'switch` bytecode op (@ branch feature/byte-switch),
which uses hash tables generated during compile time (so the constant vector
stores printed hash tables) as jump tables. This bug breaks switch entirely.
> we're planning to redo dumping anyway and can address this problem (if it still
> occurs) then.
I suspect this bug is related to purecopy, which I suppose isn't a part of the
redo (or is it? I don't know much about the new dumping code). If anyone has any
ideas about this issue, I'd appreciate some pointers on where to start.
Thanks,
Vibhav
--
Vibhav Pant
vibhavp@gmail.com
next prev parent reply other threads:[~2017-01-26 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 13:03 Critical bytecode bug with hash tables while dumping emacs Vibhav Pant
2017-01-26 17:33 ` Paul Eggert
2017-01-26 18:57 ` Vibhav Pant [this message]
2017-01-27 13:45 ` Vibhav Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+T2Sh2fD7x9F4n+euwRkuCWWhCw2_mvsTjeeoTS91kMLHYMkQ@mail.gmail.com \
--to=vibhavp@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).