unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vibhav Pant <vibhavp@ubuntu.com>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add support for custom user agent strings in url.el
Date: Sun, 19 Jan 2014 19:43:53 +0530	[thread overview]
Message-ID: <CA+T2Sh2e_znE__p=iSSmRxPCh1TCZ92=Cpht37OYtyNyFfinqQ@mail.gmail.com> (raw)
In-Reply-To: <CA+T2Sh1Rvg5=1QnuQvg_+FUOxwA4k_uDXGbKKYwnFvJbUtjLUw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

And here's the attached patch file for those whose email clients
cannot view it correctly.

-- 
Vibhav Pant
vibhavp@gmail.com

[-- Attachment #2: url-custom-user-agent.patch --]
[-- Type: text/x-patch, Size: 1289 bytes --]

commit f380c64e2b3a6c892c8f2821b0d902cf5ca9d63d
Author: Vibhav Pant <vibhavp@gmail.com>
Date:   Sun Jan 19 13:45:28 2014 +0000

    Add support for custom user agent strings.

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index ac2e140..6a0ec13 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -132,6 +132,15 @@ request.")
     (507 insufficient-storage            "Insufficient storage"))
   "The HTTP return codes and their text.")
 
+(defcustom url-user-agent (format "User-Agent: %sURL/%s\r\n"
+				  (if url-package-name
+				      (concat url-package-name "/"
+					      url-package-version " ")
+				    "") url-version)
+  "User Agent used by the URL package."
+  :type 'string
+  :group 'url)
+
 ;(eval-when-compile
 ;; These are all macros so that they are hidden from external sight
 ;; when the file is byte-compiled.
@@ -214,11 +223,7 @@ request.")
 	  (and (listp url-privacy-level)
 	       (memq 'agent url-privacy-level)))
       ""
-    (format "User-Agent: %sURL/%s\r\n"
-	    (if url-package-name
-		(concat url-package-name "/" url-package-version " ")
-	      "")
-	    url-version)))
+    url-user-agent))
 
 (defun url-http-create-request (&optional ref-url)
   "Create an HTTP request for `url-http-target-url', referred to by REF-URL."

  reply	other threads:[~2014-01-19 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-19  8:10 [PATCH] Add support for custom user agent strings in url.el Vibhav Pant
2014-01-19  8:15 ` Bozhidar Batsov
2014-01-19  8:36   ` Vibhav Pant
2014-01-19  9:12     ` Bozhidar Batsov
2014-01-19  9:45       ` Vibhav Pant
2014-01-19  9:58         ` Vibhav Pant
2014-01-19 14:13           ` Vibhav Pant [this message]
2014-01-20  9:13           ` Richard Stallman
2014-01-20 12:11             ` Rüdiger Sonderfeld
2014-01-20 12:13           ` Rüdiger Sonderfeld
2014-01-20 14:03             ` Vibhav Pant
2014-01-19 14:42         ` Stefan Monnier
2014-01-19 15:28           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+T2Sh2e_znE__p=iSSmRxPCh1TCZ92=Cpht37OYtyNyFfinqQ@mail.gmail.com' \
    --to=vibhavp@ubuntu.com \
    --cc=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).