From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Add new bytecode op `switch' for implementing branch tables. Date: Fri, 10 Feb 2017 23:29:59 +0530 Message-ID: References: <1b07c68a-873e-83c8-246d-423bc83a3881@gmail.com> <712df469-190d-aeab-e239-1f225be3333f@gmail.com> <25a6003d-1d9b-381f-29b0-aece30af1def@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1486749670 9445 195.159.176.226 (10 Feb 2017 18:01:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2017 18:01:10 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 10 19:01:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccFVJ-000292-KK for ged-emacs-devel@m.gmane.org; Fri, 10 Feb 2017 19:01:05 +0100 Original-Received: from localhost ([::1]:45286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccFVP-00087U-5P for ged-emacs-devel@m.gmane.org; Fri, 10 Feb 2017 13:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccFUd-00080f-K5 for emacs-devel@gnu.org; Fri, 10 Feb 2017 13:00:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccFUc-00083L-QM for emacs-devel@gnu.org; Fri, 10 Feb 2017 13:00:23 -0500 Original-Received: from mail-yw0-x243.google.com ([2607:f8b0:4002:c05::243]:35857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccFUc-00082I-N5 for emacs-devel@gnu.org; Fri, 10 Feb 2017 13:00:22 -0500 Original-Received: by mail-yw0-x243.google.com with SMTP id q71so3080208ywg.3 for ; Fri, 10 Feb 2017 10:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5jpQVmT3Y5BshMW1Uhlh4LoL8dRu5Y6H2SigSHu7Wik=; b=eUwZVLPCziTyyyEkoJCyxKVGkbgGfN39wa6EcebgElEBYWSlXolEtmnoQioy08pMLY 2wQw92o11nfDCtEJzDDxNfhP9OTPZ42dEFj94MzqHDpvMoTzv3XUl1OFHHz3z+f6XhIz xCkuWvhnsnF25CjxuW4vQiaZedITrq0+eCLzASRf28JGsN05JpdAv36o5bkBAiP7RkOM rSBpigPWzfhwNLJdv3yA8hxm4HrB8iGSDHlf6cJD9Xmn3EfPNGXkdo36jLys0ohMMmjp R218cPOb5Z7Y8m0zAs4OBWuBHpJCtVSFT9PSvWQidRrD8D4+bnzf7vSRdqxeb+Hka1cI gqtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5jpQVmT3Y5BshMW1Uhlh4LoL8dRu5Y6H2SigSHu7Wik=; b=CrDW0aveKVyqfaqSDAbBuZWBfZDjQsd34o/ge62qGK3APOogYYT5MTmUJPzhIJ84xd Wa2URPTZL7Q6XV58ylC0pT3L8dUvLJBjn+jE+vAPIa5GBLcddBd1kOlzi6scG3OcPNBa lPF8dEL9OI8AdRKOBhQjY3XOukzj6WHdDoa0IEJSVeE25Cpj+cyeRKAz3/rHe2aipMzv dBeReHH3RN+5vGb6yeAnPSWY54TRZqr7m5rKFsRIFU0e/EIb3HB2Cx/vGUmkYsJpen7f eqv0ikUPpAF7m3WEaQpevS4XlrGLjDFRLiNy3nng1zWMSZXn093X+wBrlxRxLxkgq6Qf pQEg== X-Gm-Message-State: AMke39n8Lv01UEFZuNi+eYdeYZNkEvZJPtn6nXF+9+DRI2J1Kkla6lLA7cj1RIPUh6DXziOY3I49SxfUhcXUoQ== X-Received: by 10.13.224.4 with SMTP id j4mr8018760ywe.139.1486749620469; Fri, 10 Feb 2017 10:00:20 -0800 (PST) Original-Received: by 10.129.153.77 with HTTP; Fri, 10 Feb 2017 09:59:59 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212211 Archived-At: On Fri, Feb 10, 2017 at 8:42 PM, Stefan Monnier wrote: >>> The linear search should compare HASH_HASH(h, i) to the search key's >>> hash anyway, so this comparison against nil is not needed. >> Is that strictly needed, though? > > No, it's an optimisation to avoid calling Fequal unnecessarily. Ah, I see, I've added this to the linear search code in bytecode.c. -- Vibhav Pant vibhavp@gmail.com