From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Weiner Newsgroups: gmane.emacs.devel Subject: Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional Date: Wed, 6 Jul 2016 11:20:46 -0400 Message-ID: References: <2f8dfb88-8174-fa42-efd3-542605c881fd@yandex.ru> <83wpkyn7pr.fsf@gnu.org> Reply-To: rswgnu@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1467818577 31063 80.91.229.3 (6 Jul 2016 15:22:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2016 15:22:57 +0000 (UTC) Cc: John Wiegley , Stefan Monnier , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 06 17:22:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bKofA-0007kj-Bo for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2016 17:22:56 +0200 Original-Received: from localhost ([::1]:34187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKof9-0001S6-FG for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2016 11:22:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKodg-00009D-KZ for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:21:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKodb-0000jy-Bl for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:21:23 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKodb-0000jG-8Q for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:21:19 -0400 Original-Received: from mail-oi0-f42.google.com ([209.85.218.42]:36325) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bKodZ-0006Ge-6n; Wed, 06 Jul 2016 11:21:17 -0400 Original-Received: by mail-oi0-f42.google.com with SMTP id f189so275101115oig.3; Wed, 06 Jul 2016 08:21:17 -0700 (PDT) X-Gm-Message-State: ALyK8tLiR5fgs/RHbuauxEyZLdBXsgw25zGHs2LoTD4Pjtg/+9wvrcfMUeGYPfdSbOijn7p1SyPBS69lwyoDqw== X-Received: by 10.202.107.210 with SMTP id g201mr806249oic.155.1467818476475; Wed, 06 Jul 2016 08:21:16 -0700 (PDT) Original-Received: by 10.202.212.143 with HTTP; Wed, 6 Jul 2016 08:20:46 -0700 (PDT) In-Reply-To: <83wpkyn7pr.fsf@gnu.org> X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205262 Archived-At: On Wed, Jul 6, 2016 at 10:48 AM, Eli Zaretskii wrote: > So: what exactly is the problem? Is it a convenience issue, or are > there some real problems in the recommended replacements for > 'interactive-p' (such as 'called-interactively-p')? I agree with Eli that a good summary, hopefully with examples, of why one always needs to give an argument to called-interactively-p would be helpful and how making its argument optional could cause problems, if that is indeed the case. I do think called-interactively-p is a better name for the function than interactive-p and that is why I originally suggested just making the argument to it optional, defaulting to the same behavior as when it is given an 'interactive argument. My first post in this thread is a good summary of why the change was suggested, which was for ease of code writing and reading, not any operational problem. Bob