* Re: emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner
[not found] ` <20160802235649.E251B220169@vcs.savannah.gnu.org>
@ 2016-08-03 15:35 ` Glenn Morris
2016-08-03 16:13 ` Robert Weiner
2016-08-03 16:42 ` Stefan Monnier
0 siblings, 2 replies; 5+ messages in thread
From: Glenn Morris @ 2016-08-03 15:35 UTC (permalink / raw)
To: emacs-devel; +Cc: John Wiegley
John Wiegley wrote:
> branch: emacs-25
> commit d35d398bdbeb393f3ebf17918d82c7573562f01e
> Author: John Wiegley <johnw@newartisans.com>
> Commit: John Wiegley <johnw@newartisans.com>
>
> Update to the AUTHORS file for Bob Weiner
AUTHORS is a generated file and should not be edited directly.
Changes will be lost the next time it is regenerated.
Instead edit admin/authors.el, or fix the ChangeLogs.
Probably you want authors-fixed-entries in this case.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner
2016-08-03 15:35 ` emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner Glenn Morris
@ 2016-08-03 16:13 ` Robert Weiner
2016-08-03 16:42 ` Stefan Monnier
1 sibling, 0 replies; 5+ messages in thread
From: Robert Weiner @ 2016-08-03 16:13 UTC (permalink / raw)
To: Glenn Morris; +Cc: John Wiegley, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On Wed, Aug 3, 2016 at 11:35 AM, Glenn Morris <rgm@gnu.org> wrote:
> AUTHORS is a generated file and should not be edited directly.
> Changes will be lost the next time it is regenerated.
> Instead edit admin/authors.el, or fix the ChangeLogs.
> Probably you want authors-fixed-entries in this case.
>
Ok. Why not add a sentence at the top of the generated file that says,
This is an auto-generated file, don't edit this, edit admin/authors.el to
avoid any question in the future.
Bob
[-- Attachment #2: Type: text/html, Size: 1179 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner
2016-08-03 15:35 ` emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner Glenn Morris
2016-08-03 16:13 ` Robert Weiner
@ 2016-08-03 16:42 ` Stefan Monnier
2016-08-08 15:35 ` Glenn Morris
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2016-08-03 16:42 UTC (permalink / raw)
To: emacs-devel
> AUTHORS is a generated file and should not be edited directly.
Any reason we keep it in Git, then?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner
2016-08-03 16:42 ` Stefan Monnier
@ 2016-08-08 15:35 ` Glenn Morris
2016-08-08 16:33 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2016-08-08 15:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
>> AUTHORS is a generated file and should not be edited directly.
>
> Any reason we keep it in Git, then?
I was waiting for someone to ask that...
It's not essential to keep it in the repo. However, it is slow to
regenerate (so slow that you would not want to add it to a normal build
target, so removing it from the the repo means most non-tarball installs
would simply not contain any version, which I think would be a shame),
rarely changes (only when a pretest is made), and never causes merge
conflicts (pretests only happen on one branch), and IMO it is nice to
have a version always present. So why not leave it as-is.
PS please try to use reply-to-all, not reply-to-list.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner
2016-08-08 15:35 ` Glenn Morris
@ 2016-08-08 16:33 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2016-08-08 16:33 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> It's not essential to keep it in the repo. However, it is slow to
> regenerate (so slow that you would not want to add it to a normal build
> target, so removing it from the the repo means most non-tarball installs
> would simply not contain any version, which I think would be a shame),
Makes sense.
> PS please try to use reply-to-all, not reply-to-list.
I always do, but for some reason it doesn't seem to DTRT when I reply
via Gmane.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-08 16:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160802235649.3930.79230@vcs.savannah.gnu.org>
[not found] ` <20160802235649.E251B220169@vcs.savannah.gnu.org>
2016-08-03 15:35 ` emacs-25 d35d398: Update to the AUTHORS file for Bob Weiner Glenn Morris
2016-08-03 16:13 ` Robert Weiner
2016-08-03 16:42 ` Stefan Monnier
2016-08-08 15:35 ` Glenn Morris
2016-08-08 16:33 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).