From: Robert Weiner <rsw@gnu.org>
To: Justin Burkett <justin@burkett.cc>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Proposed patch for lookup-key
Date: Thu, 14 Dec 2017 16:07:45 -0500 [thread overview]
Message-ID: <CA+OMD9h4zeAuiNrFatSZW799fgFAqK7U+vCVLCZe=YzO2MS46w@mail.gmail.com> (raw)
In-Reply-To: <CAF8XuLh3JhL3aiN0ZNp=akiiMhd9-zhKH5tnqZp4gFVx0e+CHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
Nice effort for a first contribution!
How about showing what the lookup-key output looks like before and after
your patch when a menu is involved?
Bob
[-- Attachment #2: Type: text/html, Size: 623 bytes --]
next prev parent reply other threads:[~2017-12-14 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 19:44 Proposed patch for lookup-key Justin Burkett
2017-12-14 21:07 ` Robert Weiner [this message]
2017-12-14 21:25 ` Justin Burkett
2017-12-15 1:31 ` Justin Burkett
2017-12-15 2:57 ` Stefan Monnier
2017-12-15 14:55 ` Justin Burkett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+OMD9h4zeAuiNrFatSZW799fgFAqK7U+vCVLCZe=YzO2MS46w@mail.gmail.com' \
--to=rsw@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=justin@burkett.cc \
--cc=rswgnu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).