Re: [PATCH] hack-one-local-variable use lexical-binding

[Tom Gillespie <tgbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

> I think we should just always pass `t` to `eval` there, yes.
> The other option is over-engineered.

Agreed. Here is the updated patch. I'm guessing this will need a NEWS item?

Best,
Tom

[-- Attachment #2: 0001-hack-one-local-variable-eval-with-LEXICAL-t.patch --]
[-- Type: text/x-patch, Size: 884 bytes --]

From d1b261faaed22f92a2c61ce43236a77221b6ce74 Mon Sep 17 00:00:00 2001
From: Tom Gillespie <tgbugs@gmail.com>
Date: Wed, 25 Nov 2020 23:37:36 -0500
Subject: [PATCH] hack-one-local-variable eval with LEXICAL t

* lisp/files.el (hack-one-local-variable): call eval with LEXICAL t

Change the behavior of eval: local variables to use lexical binding.
---
 lisp/files.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/files.el b/lisp/files.el
index 49c9e5d18d..f6c1c44718 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3984,7 +3984,7 @@ hack-one-local-variable
     ('eval
      (pcase val
        (`(add-hook ',hook . ,_) (hack-one-local-variable--obsolete hook)))
-     (save-excursion (eval val)))
+     (save-excursion (eval val t)))
     (_
      (hack-one-local-variable--obsolete var)
      ;; Make sure the string has no text properties.
-- 
2.26.2