Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding

[Tom Gillespie <tgbugs@gmail.com>]

> There probably won't be a 27.3...

Ok, good to know.

> > -           (subst-char-in-region (point) (point-max) ?\^m ?\n)
> > +           (unless noconv
> > +             (subst-char-in-region (point) (point-max) ?\^m ?\n))
>
> I don't quite understand the logic here -- shouldn't this be a
>
>               (when noconv

No, when we read a file literally we don't want to normalize anything.
The issue is that 'when noconv' is set (i.e. we are in find-file-literally)
then we don't want to convert ?\^m because the value of suffix
contains ?\^m. Does this make sense? I tried other approaches
including modifying the suffix but this one was by far the cleanest.

> ?  That is, if we're visiting the file literally, we want to delete the
> carriage returns, but not otherwise?  (If we're not visiting the file
> literally, the CRLFs will already have been translated into newlines.)
>
> > +          (with-current-buffer (find-file-literally tempfile)
> > +            (hack-local-variables)))
>
> Should probably be a `should' in here to make it work as a test, I think.

I think that is right, it kind of works at the moment because the previous
behavior produces an error.