unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tom Gillespie <tgbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding
Date: Sun, 15 Aug 2021 15:31:40 -0700	[thread overview]
Message-ID: <CA+G3_PNba2M3cpTAMY=mrsyRximf_mQg1RMtq9fnk03u79k6ow@mail.gmail.com> (raw)
In-Reply-To: <87fsvagxt8.fsf@gnus.org>

> Looking at the existing code here, I think that `subst-char-in-region'
> is wrong in any case, but following the history of that function is
> pretty difficult.  It might have originated here?

I was equally confused, so I left it alone.

> If the intention is to fix up DOS line endings, when it's the wrong
> thing -- it should transform \r\n to \n, not transform any \r anywhere
> in a line to \n...

I agree, what is strange to me is that as far as I can tell it should
be causing a bug by introducing blank lines in the temporary buffer
but somehow is not? I think the reason it is not might be because
subst-char-in-region doesn't actually do anything if the buffer has
dos encoding.

I think we might be able to remove the line entirely?



  reply	other threads:[~2021-08-15 22:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-15 21:23 [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Tom Gillespie
2021-08-15 21:35 ` Tom Gillespie
2021-08-15 21:52 ` Lars Ingebrigtsen
2021-08-15 22:14   ` Lars Ingebrigtsen
2021-08-15 22:31     ` Tom Gillespie [this message]
2021-08-15 22:21   ` Tom Gillespie
2021-08-15 22:39     ` Tom Gillespie
2021-08-15 23:09       ` Tom Gillespie
2021-08-16 11:32         ` Eli Zaretskii
2021-08-16 12:01     ` Lars Ingebrigtsen
2021-08-16 12:06       ` Lars Ingebrigtsen
2021-08-16 12:29       ` Eli Zaretskii
2021-08-16 12:53         ` Lars Ingebrigtsen
2021-08-16 13:22           ` Eli Zaretskii
2021-08-16 17:44             ` Tom Gillespie
2021-08-16 17:49               ` Stefan Monnier
2021-08-16 18:09                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+G3_PNba2M3cpTAMY=mrsyRximf_mQg1RMtq9fnk03u79k6ow@mail.gmail.com' \
    --to=tgbugs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).