From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Sat, 11 Feb 2023 13:15:22 -0500 Message-ID: References: <30c3d810-ed96-a9bd-c622-1761a138515c@gmx.at> <115a6020-2b86-2653-844e-d19eb03cf62c@gmx.at> <94366f16-89d2-68dc-06cd-0989b9dd2698@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 11 19:16:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQuQ6-0007tI-Tc for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Feb 2023 19:16:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQuPS-0007Ql-Vs; Sat, 11 Feb 2023 13:15:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQuPR-0007QE-IZ for emacs-devel@gnu.org; Sat, 11 Feb 2023 13:15:37 -0500 Original-Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQuPP-0002gS-V0; Sat, 11 Feb 2023 13:15:37 -0500 Original-Received: by mail-yb1-xb36.google.com with SMTP id g2so9941077ybk.8; Sat, 11 Feb 2023 10:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ob1annnDBRClMzAJttepJEeXAkPzBn3FCX2KKR08ZRA=; b=LIJoUwV5kGYVtK2Qiy83bQy68iQOJoNvMsHVgaHp84UvLHIZOzzG4IaKcjbnD7uhk6 g/1WpAvp4IQkg2c6E0XfwpnuVqJeFTjemywG1RWQfihiolnLp2x48BmWvUjb2LWEllTX hOSiso7Ltig4D2vEgE8M+Nv8x/J2rTzhGIF2AC920gJJEYBw1HF8b83In1KKWj39IHnA 1XuwvEi+/QJVFz7xjxIkF0UBN6z7ZJuaiXep1GRoLJf+xrF/bp2PhmVppBdh7cSQ8x/K BSh2wAnJ5gRqdymhmROyHCQvnMgKg0NaV73VhSjd2L8/Yc0Wl0WbYUse1Klea8TxEMFY c8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ob1annnDBRClMzAJttepJEeXAkPzBn3FCX2KKR08ZRA=; b=TMxVUFubh5O+opbelx1wfzWJ+p5cU3jOrpvRL5LqxhGSJJpiionxx0TiSB/x3pFd86 yX/yhI+u2zABvQa0rSt+Y8AqQlPLhwyzDo7KbLt1HTGAlzBMvnikhP90OtmYbjB8Y5Zp 1MyZ03Nj8dMtChiJUZt31osVfrX38IZUT6gI2LTx9qdRch/W+zPgxsMJcaRA36LKrwrN 5KnBMMuaJDuOo9FWvGfM3a8udKRh7+F69QE57Q9EMZs4MULRfMhuRHo9Ycb70oZ5+5Oo sZ8FLrAqCvuc1EYJRKrbTXG+aOy2n7x4tCcPfFKGqJqsiq6/wzi500OXxpj/7Om8ZPhm VzDQ== X-Gm-Message-State: AO0yUKUKK2Lp3OETiXMRbDBJYn6zqEfLTUJgWkVilieIAqvWXQena9xo 2+pCECsgxoZP70dL5olFJea4RZs0Q6S3ea1szpg= X-Google-Smtp-Source: AK7set8iF8tDAiqgGj4Tfk0nOdUG9bMa5O5cCYn38TO6w399iToiT1il32Czfmay9I1XSQngs6pXlNF3Xc8N6gqE02s= X-Received: by 2002:a5b:c4d:0:b0:80b:6539:f761 with SMTP id d13-20020a5b0c4d000000b0080b6539f761mr2000344ybr.8.1676139333977; Sat, 11 Feb 2023 10:15:33 -0800 (PST) In-Reply-To: <94366f16-89d2-68dc-06cd-0989b9dd2698@gmx.at> Received-SPF: pass client-ip=2607:f8b0:4864:20::b36; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303150 Archived-At: Apologies for the delay. The updated patch works as expected. There is still some strangeness if '((display-buffer-use-least-recent-window)) is used by itself as compared to using '((display-buffer-reuse-window display-buffer-use-least-recent-window)) Specifically, when exiting an org-src-edit buffer, display-buffer-reuse-window must be present to prevent display-buffer-use-least-recent-window from persisting the pop-up window and/or changing a reused window to the buffer for the org file. I don't think this is a blocker however, because it is not entirely clear where the issue lies, whether it is with how org-edit-special sets up for restoring buffers, or whether there is something that is off in the most recent implementation of display-buffer-use-least-recent-window. I think we are ok to proceed with the latest patch. > Sorry. I don't grok what you said in parentheses here. It was and aside about using the new code to enable display of multiple buffers at the same time, it is not relevant here.