From: Jim Meyering <jim@meyering.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: automake's .el support vs. recent loss of byte-compile-dest-file
Date: Wed, 29 Nov 2017 18:28:02 -0800 [thread overview]
Message-ID: <CA+8g5KHSiKscCsY0s7eMKzTtSeLpjw7bkb2cRHUhFC5Yf6CT5w@mail.gmail.com> (raw)
In-Reply-To: <837eu93pvp.fsf@gnu.org>
On Wed, Nov 29, 2017 at 10:23 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jim Meyering <jim@meyering.net>
>> Date: Tue, 28 Nov 2017 19:35:04 -0800
>> Cc: emacs-devel <emacs-devel@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>
>>
>> $ (export TMPDIR=/tmp; mkdir sub && : > sub/x.el && emacs --batch -l
>> bytecomp --eval '(defun byte-compile-dest-file (f) "sub/x.elc")'
>> --eval "(unless (byte-compile-file \"sub/x.el\") (kill-emacs 1))" )
>> Creating file with prefix: No such file or directory, /tmp/sub/x.elc
>
> Does the patch below fix this?
>
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index e4d8a20..fa6b789 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -1924,7 +1924,8 @@ byte-compile-file
> ;; process is trying to load target-file (eg in a
> ;; parallel bootstrap), it does not risk getting a
> ;; half-finished file. (Bug#4196)
> - (tempfile (make-temp-file target-file))
> + (tempfile
> + (make-temp-file (file-name-nondirectory target-file)))
> (default-modes (default-file-modes))
> (temp-modes (logand default-modes #o600))
> (desired-modes (logand default-modes #o666))
Hi Eli,
Yes, with emacs built from latest master plus your patch, running
automake's lisp-related tests now (with my in-preparation patch)
succeeds. I.e., these passed:
make check TESTS="$(echo t/lisp*.sh)"
next prev parent reply other threads:[~2017-11-30 2:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 4:41 automake's .el support vs. recent loss of byte-compile-dest-file Jim Meyering
2017-11-23 4:56 ` Paul Eggert
2017-11-23 5:02 ` Jim Meyering
2017-11-23 6:34 ` Eli Zaretskii
2017-11-23 16:13 ` Jim Meyering
2017-11-23 16:37 ` Eli Zaretskii
2017-11-27 1:17 ` Jim Meyering
2017-11-27 16:36 ` Eli Zaretskii
2017-11-29 3:35 ` Jim Meyering
2017-11-29 6:44 ` Paul Eggert
2017-11-29 18:23 ` Eli Zaretskii
2017-11-30 2:28 ` Jim Meyering [this message]
2017-12-02 11:32 ` Eli Zaretskii
2017-12-02 11:37 ` Eli Zaretskii
2017-12-02 11:57 ` Eli Zaretskii
2017-12-17 0:34 ` Jim Meyering
2017-12-17 15:33 ` Eli Zaretskii
2017-12-04 3:18 ` Glenn Morris
2017-12-04 3:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+8g5KHSiKscCsY0s7eMKzTtSeLpjw7bkb2cRHUhFC5Yf6CT5w@mail.gmail.com \
--to=jim@meyering.net \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).