unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: automake's .el support vs. recent loss of byte-compile-dest-file
Date: Tue, 28 Nov 2017 19:35:04 -0800	[thread overview]
Message-ID: <CA+8g5KGXXk92DfObTE6HKb5gaM-a+CSM96QBw09u1U_KV1ZWbg@mail.gmail.com> (raw)
In-Reply-To: <83k1yb65mk.fsf@gnu.org>

On Mon, Nov 27, 2017 at 8:36 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jim Meyering <jim@meyering.net>
>> Date: Sun, 26 Nov 2017 17:17:59 -0800
>> Cc: emacs-devel <emacs-devel@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>
>>
>> >> I've just posted an automake fix:
>> >> https://lists.gnu.org/archive/html/automake/2017-11/msg00038.html
>> >
>> > Thanks.  The question that's important to us is, of course, when will
>> > this fixed version be available widely enough for us to consider
>> > removing the support for the old ones.
>>
>> I agree. What Emacs does here will influence at least the wording of
>> the automake NEWS entry for that automake change I mentioned. Should I
>> call it a bug fix, because this behavior will make it into a release?
>> Or is it just a work-around for those who happen to be using
>> pre-release Emacs, and it won't affect anyone using an actual release?
>
> My intention, unless I hear objections, is to resurrect the removed
> feature on the emacs-26 branch, but add an annoying warning there, so
> that any packages and maintainers who didn't notice the deprecation
> will do so sooner rather than later.  But the feature will remain
> removed on the master branch, which will eventually become Emacs 27.
> So I think your change is a bug fix, and its purpose is to make
> Automake future-proof against imminent changes in Emacs.  It is also
> for those who already use development snapshots of Emacs 27, because
> the function will remain removed there.

Thanks.
Another possible fix proposed by Glenn was to use -l bytecomp and to
continue to override byte-compile-dest-file.
However, I have hit a new seemingly unrelated snag: subdirs. This now
fails, where the argument to byte-compile-file is a dot-relative name
in a subdirectory:

$ (export TMPDIR=/tmp; mkdir sub && : > sub/x.el && emacs --batch -l
bytecomp --eval '(defun byte-compile-dest-file (f) "sub/x.elc")'
--eval "(unless (byte-compile-file \"sub/x.el\") (kill-emacs 1))" )
Creating file with prefix: No such file or directory, /tmp/sub/x.elc

While it worked fine with emacs built from a commit on master from
2017-07-29, some time between then and Aug 11, things changed so that
byte-compiling such a source file name requires the relative directory
name first be created in $TMPDIR.

Was that deliberate?

For reference, this was exposed because an automake test exercises
that code path: I ran it individually via this: make check
TESTS='t/lisp-subdir.sh'



  reply	other threads:[~2017-11-29  3:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  4:41 automake's .el support vs. recent loss of byte-compile-dest-file Jim Meyering
2017-11-23  4:56 ` Paul Eggert
2017-11-23  5:02   ` Jim Meyering
2017-11-23  6:34     ` Eli Zaretskii
2017-11-23 16:13       ` Jim Meyering
2017-11-23 16:37         ` Eli Zaretskii
2017-11-27  1:17           ` Jim Meyering
2017-11-27 16:36             ` Eli Zaretskii
2017-11-29  3:35               ` Jim Meyering [this message]
2017-11-29  6:44                 ` Paul Eggert
2017-11-29 18:23                 ` Eli Zaretskii
2017-11-30  2:28                   ` Jim Meyering
2017-12-02 11:32                     ` Eli Zaretskii
2017-12-02 11:37               ` Eli Zaretskii
2017-12-02 11:57                 ` Eli Zaretskii
2017-12-17  0:34                   ` Jim Meyering
2017-12-17 15:33                     ` Eli Zaretskii
2017-12-04  3:18                 ` Glenn Morris
2017-12-04  3:41                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+8g5KGXXk92DfObTE6HKb5gaM-a+CSM96QBw09u1U_KV1ZWbg@mail.gmail.com \
    --to=jim@meyering.net \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).