From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Newsgroups: gmane.emacs.devel Subject: Re: [patch] add "underwave" face attribute Date: Mon, 6 Feb 2012 01:55:50 +0100 Message-ID: References: <037B3467A9FE4EC9B681DF3B1171A539@us.oracle.com> <87obtii1y4.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1328489759 17701 80.91.229.3 (6 Feb 2012 00:55:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Feb 2012 00:55:59 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org, Juri Linkov , Stefan Monnier , =?UTF-8?Q?Jan_Dj=C3=A4rv?= , Drew Adams To: Alp Aker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 06 01:55:57 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RuCs9-0002CF-3n for ged-emacs-devel@m.gmane.org; Mon, 06 Feb 2012 01:55:57 +0100 Original-Received: from localhost ([::1]:42747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuCs7-0002Sh-Rz for ged-emacs-devel@m.gmane.org; Sun, 05 Feb 2012 19:55:55 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:47549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuCs4-0002SP-S4 for emacs-devel@gnu.org; Sun, 05 Feb 2012 19:55:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuCs3-0007qB-TS for emacs-devel@gnu.org; Sun, 05 Feb 2012 19:55:52 -0500 Original-Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:53899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuCs3-0007q7-Od for emacs-devel@gnu.org; Sun, 05 Feb 2012 19:55:51 -0500 Original-Received: by obbta7 with SMTP id ta7so7813059obb.0 for ; Sun, 05 Feb 2012 16:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=MaovWOQOUuoS3t0jdyevupnx78SVQdM2GtJb5n4xj4M=; b=XDR//SLXE5q0N4pkYCrNfcA7ZkLaNGmoVTqE+I0dslhc/NCXO7WuFyeSMplmSzU7Hp vJRSc8Dwp5PReSXDhOECpBTixG7F+gr/l/cGt7Uzz7fSPXbTrvus8O2o0oK8lVj+U5TH opW5Q7XYAypPizBgV+/piwhOhvst5tDgnnW+A= Original-Received: by 10.182.74.102 with SMTP id s6mr14843854obv.46.1328489751011; Sun, 05 Feb 2012 16:55:51 -0800 (PST) Original-Received: by 10.182.11.166 with HTTP; Sun, 5 Feb 2012 16:55:50 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: tkt9Arpvpw08a8Vvjhr-SS_9qvE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148220 Archived-At: On Mon, Feb 6, 2012 at 1:18 AM, Alp Aker wrote: > (1) I changed the API calls for the clipping. Are you sure this won't break the rest of the code? (which relies heavily on clipping) It sure looks cleaner but the rest of the code uses ns_focus/unfocus. > (2) Because of the way the NS port handles cursor drawing, one can't extr= act > the x-origin and width for the underwave directly from the glyph string a= s > you did. =C2=A0I made the appropriate changes. You're correct. I should have looked closer at the underline code. Then again I wrote the code blindly :p > (3) On the various displays I tried, changing wave_height from 2 to 3 > dramatically improved the appearance. I took the liberty of using the lat= ter > value. =C2=A0(Perhaps wave_height and wave_length should be exposed to th= e user > as options?) Set them to the best looking value. The screenshot looks nice. We could expose it as options but wave_height has a short upper limit: the wave gets cropped above a certain value. I don't know if there's a *simple* way to make the "line space" higher to handle this.