unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Aurélien Aptel" <aurelien.aptel+emacs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Ted Zlatanov <tzz@lifelogs.com>,
	Daniel Colascione <dancol@dancol.org>,
	Philipp Stephani <p.stephani2@gmail.com>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Reporting Lisp errors in dynamic modules
Date: Fri, 27 Nov 2015 13:49:39 +0100	[thread overview]
Message-ID: <CA+5B0FPLvwqEs7YorVfGsCbmvWap-LJV-YYx8i-rgMs_Hjf9qA@mail.gmail.com> (raw)
In-Reply-To: <83d1uvsm0u.fsf@gnu.org>

On Fri, Nov 27, 2015 at 12:46 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> It's an implementation detail and cannot be used safely by Lisp users.
>> The danger of using it is it can make core Emacs crash.
>
> How can it cause Emacs to crash?  Can you show a specific scenario?
> We should be able to prevent that.

You cannot allocate a valid struct module_fun_env embedded in a
save_value from Lisp (first expected argument of 'module-call').
Therefore any call to 'module-call' from Lisp is invalid. It's an
implementation detail and shouldn't be used directly by users.

>> We also don't want the risk of someone overriding it.
> How is that different from any other primitive?

It's the same.

>> Also, unrelated but can I be added to the savannah emacs group? My
>> savannah account is aaptel.
> Please apply, and please explain your interests.

I already signed the copyright assignment papers few years ago. I've
already contributed a few things here and there (underwave support)
and finally I initiated and spent most of a year working on this
dynamic module feature, along with Philip Stephani. Is there anything
else I should do?



  reply	other threads:[~2015-11-27 12:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 11:07 Reporting Lisp errors in dynamic modules Eli Zaretskii
2015-11-27 11:20 ` Aurélien Aptel
2015-11-27 11:46   ` Eli Zaretskii
2015-11-27 12:49     ` Aurélien Aptel [this message]
2015-11-27 12:53       ` David Kastrup
2015-11-27 14:50       ` Eli Zaretskii
2015-11-27 16:40 ` Philipp Stephani
2015-11-27 17:39   ` Eli Zaretskii
2015-11-27 18:01     ` Philipp Stephani
2015-11-27 18:11       ` Eli Zaretskii
2015-11-27 18:40         ` Philipp Stephani
2015-11-28 12:04           ` Eli Zaretskii
2015-12-03  5:00   ` Stefan Monnier
2015-12-03 11:33     ` Aurélien Aptel
2015-12-03 13:42       ` Ted Zlatanov
2015-12-03 15:37       ` Stefan Monnier
2015-12-07 19:13       ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+5B0FPLvwqEs7YorVfGsCbmvWap-LJV-YYx8i-rgMs_Hjf9qA@mail.gmail.com \
    --to=aurelien.aptel+emacs@gmail.com \
    --cc=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).