From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: Carbon / USE_MAC_TOOLBAR: click in tool bar doesn't raise frame Date: Thu, 17 Apr 2008 10:22:03 +0100 Message-ID: References: <20ecf6c70804160707t7e7881c4wdf0fbdc28b2f9bb7@mail.gmail.com> <83110B73-CA3A-42CA-B4D5-E25F66D805E1@gmail.com> <6D441F87-8AC4-42FD-9DA9-12E9AF43CC28@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1208424372 32324 80.91.229.12 (17 Apr 2008 09:26:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Apr 2008 09:26:12 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Nathaniel Cunningham To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 11:26:11 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmQKd-0001o6-1l for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 11:23:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmQJy-0003nA-B4 for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 05:22:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmQJs-0003n3-Aa for emacs-devel@gnu.org; Thu, 17 Apr 2008 05:22:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmQJp-0003mo-Gx for emacs-devel@gnu.org; Thu, 17 Apr 2008 05:22:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmQJp-0003mj-7k for emacs-devel@gnu.org; Thu, 17 Apr 2008 05:22:13 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmQJo-0004Y2-TM for emacs-devel@gnu.org; Thu, 17 Apr 2008 05:22:13 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JmQJo-0002EM-LN for emacs-pretest-bug@gnu.org; Thu, 17 Apr 2008 05:22:12 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JmQJk-0004Wy-0x for emacs-pretest-bug@gnu.org; Thu, 17 Apr 2008 05:22:12 -0400 Original-Received: from fk-out-0910.google.com ([209.85.128.191]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmQJj-0004Wo-My for emacs-pretest-bug@gnu.org; Thu, 17 Apr 2008 05:22:07 -0400 Original-Received: by fk-out-0910.google.com with SMTP id 26so3255346fkx.10 for ; Thu, 17 Apr 2008 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer; bh=ZuWFYDSy0oWrQY4srV6O5kBmAeAznLISuzYWXNhX5Kw=; b=UpZWi4UifZhhDBl9z+fJoVq8BFoGU+ewZwwu24ppO5nrxoixDQw/BZTat6IVfSuQE5+TBbaO+lB9Ftr2RqBYm2XhLB58FxlZD/GVn6WRMqdk4e/5iZKBNfWmORXJ0kgcBxhTB6Nu5a+C/x5TICo3wVk769rmRWHKzyDEiMS5Q18= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer; b=i2xKXxJwY8czX20u25CGCKZbxkinnShcLv+SRGjTvuvdZ7akDP5EUdRNM8qYhGvQjLlRd8UrKpZU2FB+Qq2o8u4Du8qVcORrUwyFB9feRZcxBZJZi+puTVE5MBMFizD8ioXKN1ZBsXpgFTwULgm2h76cSLCrIOZr2lEIfX/A9+Q= Original-Received: by 10.82.185.3 with SMTP id i3mr1841926buf.67.1208424126815; Thu, 17 Apr 2008 02:22:06 -0700 (PDT) Original-Received: from scarlett.inf.ed.ac.uk ( [129.215.174.113]) by mx.google.com with ESMTPS id k9sm8717713nfh.35.2008.04.17.02.22.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 17 Apr 2008 02:22:05 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.919.2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95395 gmane.emacs.pretest.bugs:22057 Archived-At: On 17 Apr 2008, at 09:02, YAMAMOTO Mitsuharu wrote: >> Yes, of course that selects the window, but it does so even when the >> button can be selected otherwise, i.e. there's no "click-through". > > Maybe I don't understand. I think they've been always click-through > even without the patch. What do you mean by "select the button"? Yes, they have been click-through, without the patch. With your patch, frames are selected unconditionally, and they shouldn't be. Toolbar items should be clickable without selecting (and raising) the frame, if they are actually enabled. This is called "click-through". If they are not enabled (:enabled nil), then clicking on them should result in the frame being raised and selected. The same applies to any other click on a non-enabled surface. Most toolbar items should respond to click-through. Some dangerous actions (which cannot easily be undone) should lead to the associated item being disabled when the frame is not selected. As a consequence, users will click on the toolbar item, which will raise / select the frame. That way, the item becomes enabled and can be clicked normally. Note that this last part is not to be implemented by the C layer. Toolbar items can have that simply in their :enabled property. N.B., this is not a specific feature; it's merely the correct way of doing the UI with this particular toolkit. Other toolkits may have different standards. Refer to: http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGWindows/chapter_18_section_5.html (heading: Click-Through)