From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 18:07:41 +0200 Message-ID: References: <87wnrpujo0.fsf@osv.gnss.ru> <871r9w5jws.fsf_-_@osv.gnss.ru> <83a6okdx60.fsf@gnu.org> <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> <835yz8dvfk.fsf@gnu.org> <87wnroxi4d.fsf@osv.gnss.ru> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Eli Zaretskii , emacs-devel@gnu.org, cpitclaudel@gmail.com, monnier@iro.umontreal.ca To: Sergey Organov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 18:09:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llD8a-0008eB-1T for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 18:09:04 +0200 Original-Received: from localhost ([::1]:41362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llD8Z-0005km-5C for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 12:09:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llD7L-0004H6-OQ for emacs-devel@gnu.org; Mon, 24 May 2021 12:07:47 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:45705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llD7K-0000XV-CH; Mon, 24 May 2021 12:07:47 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id x7so9486738wrt.12; Mon, 24 May 2021 09:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1QrFFtZYPcXLE5n5knPTgro6X+2yHJyySGtaoTRbgIE=; b=kjkYiLroFUGdpKSdnrEESiWeERjqYY3JCMYlIrKl62Kf2NJi0SHEGXZRMJ1Dbom6XJ 4OA36fy6FG/xB/ePy0ROYG0tWEmGBKHQVL1rlcv/YJUfEhQSr0ayOu0W1kbTYV9zYO3v SkyqNMKJfLux1cRMoURsHCVrRFLMroyV+Gen9nauf94/HqqujS4t2wdu5S+0uqpqQGbe ngoRz21+eMU2sJdCi1jm497gxYhcPR+ONgNK6mhe8GozVbjYT/k1vBRyONTgD2j7owCs Q1PQnGKxEtvx8ITPtUUcfd/uj16RxkQaXl/dESEw4vbF9vU4H8SxNU50DIYw8I4EcAYu eu/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1QrFFtZYPcXLE5n5knPTgro6X+2yHJyySGtaoTRbgIE=; b=RFDpCB8wef38u86CQYGgumvnhuRFntgPl2KxPyN+lwJsNNWXYv0nqCV8jFy3Ae/Cat 9TPiV7tSxDMF4OlJEKM61wbUMW4wzOZZ4Of9rgWgoKeFqzQaNcUvt3premroWF0bU7oy F2HsZprfFWE7a2lr+v8MobAGcXUCtsq9Enc/WDYxYbZ2WKSb0xXnbxzuvx+BZGYz1ssc 7luVxr8owH4PAYljfSkGGgevce5pBzUr/38m7E7g1iLS9810el4MI7HLZnWUDgCsbZc1 b9x1LJUNmd+4iXrvKrpU5dBaDcQYvC+4pMT1jxBwJ3vCqqupkKoywcs8laiiQyWVi8MH 2Kpw== X-Gm-Message-State: AOAM530TFiIDBW6sX1jJmKpTtGQ2uOTTfXaa+Ei1ioLsfsHoXgUl4wmy NhLxJtsMiScArU3InU29eZQ= X-Google-Smtp-Source: ABdhPJwQOAoS2IlXN+twICTPDRSx3xpK4KZIjbtiKkSAjRUR+5j1EZLNLJhbqbtgJK+dWX60l+EAew== X-Received: by 2002:a5d:654f:: with SMTP id z15mr22666908wrv.64.1621872462915; Mon, 24 May 2021 09:07:42 -0700 (PDT) Original-Received: from smtpclient.apple ([46.128.198.100]) by smtp.gmail.com with ESMTPSA id i11sm12956902wrq.26.2021.05.24.09.07.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 May 2021 09:07:42 -0700 (PDT) In-Reply-To: <87wnroxi4d.fsf@osv.gnss.ru> X-Mailer: Apple Mail (2.3654.80.0.2.43) Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269769 Archived-At: > Am 24.05.2021 um 17:32 schrieb Sergey Organov : >=20 > Eli Zaretskii writes: >=20 >>> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, = emacs-devel@gnu.org >>> From: martin rudalics >>> Date: Mon, 24 May 2021 16:50:48 +0200 >>>=20 >>>>> + (unless (or (nill bufname) >>>>> + (eq (aref bufname 0) ?\s) ;; Don't kill internal = buffers >>>>> (string-match-p preserve-regexp bufname)) >>>>> (kill-buffer buffer))))) >>>>> (delete-other-windows) >>>>=20 >>>> AFAICT, kill-buffer already is a no-op when the buffer is dead. So >>>> what exactly does this fix? (Apologies if I'm missing something: I >>>> cannot say that I've read all the discussions in this thread to the >>>> last detail.) >>>=20 >>> Sergey never told us but it's likely `aref' choking on nil. >>=20 >> Then why not use buffer-live-p? >=20 > Cause aref is choking on bufname being nil, I think. What if > representation of killed buffers change? That won't happen. The ELisp manual guarantees that "[t]he = =E2=80=98buffer-name=E2=80=99 of a buffer is =E2=80=98nil=E2=80=99 if, = and only if, the buffer is killed."=