From: "Mattias Engdegård" <mattiase@acm.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Stefan Kangas <stefankangas@gmail.com>,
emacs-devel@gnu.org, Lennart Borgman <lennart.borgman@gmail.com>
Subject: Re: master updated (4b1ab18391 -> 8517d1e9aa)
Date: Fri, 19 Aug 2022 14:00:49 +0200 [thread overview]
Message-ID: <C755AEB6-B5CF-4C66-8285-7CFA615F6EF6@acm.org> (raw)
In-Reply-To: <8735duwzjr.fsf@tcd.ie>
17 aug. 2022 kl. 19.27 skrev Basil L. Contovounesios <contovob@tcd.ie>:
> I took the liberty of fixing these C-isms (falla-Cs?):
Thank you!
>> edmacro.el:629:19: Warning: value returned from (logand (aref seq i)
>> 128) is unused
>
> I leave this similar falla-C for someone else.
Did it myself after some hesitating, but the stakes are low in this case.
>> emacs-lisp/re-builder.el:739:29: Warning: value returned from (memq
>> 'font-lock-string-face face) is unused
>
> This one's curious: the entire surrounding (or ...) expression always
> evals to non-nil. Lennart?
That (or ... t) looks like debugging code left in by mistake, but who knows.
prev parent reply other threads:[~2022-08-19 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166067551220.16571.3552675760321814129@vcs2.savannah.gnu.org>
2022-08-17 11:13 ` master updated (4b1ab18391 -> 8517d1e9aa) Stefan Kangas
2022-08-17 11:45 ` Mattias Engdegård
2022-08-17 17:27 ` Basil L. Contovounesios
2022-08-19 12:00 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C755AEB6-B5CF-4C66-8285-7CFA615F6EF6@acm.org \
--to=mattiase@acm.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=lennart.borgman@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).