From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 64e25cd: More robust NS hex colour string parsing Date: Sat, 13 Jun 2020 19:29:33 +0200 Message-ID: References: <20200608120746.30163.87810@vcs0.savannah.gnu.org> <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org> <83r1uk429y.fsf@gnu.org> <3C92A091-F389-4179-B2F0-B3AA5ABD6CCE@acm.org> <83pna43xrl.fsf@gnu.org> <9259B4A6-F3CC-4243-9F08-2882993C9B2C@acm.org> <83a71741mr.fsf@gnu.org> <83y2or2c0o.fsf@gnu.org> <82DE05DD-0F2A-4722-AB75-D9D95F58BAF4@acm.org> <83v9ju3nbl.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="19003"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 19:30:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jk9zC-0004pz-C8 for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 19:30:30 +0200 Original-Received: from localhost ([::1]:58506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk9zB-0007MX-Dk for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 13:30:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk9yT-0006eH-UJ for emacs-devel@gnu.org; Sat, 13 Jun 2020 13:29:46 -0400 Original-Received: from mail1474c50.megamailservers.eu ([91.136.14.74]:34292 helo=mail102c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk9yS-0001DP-0l; Sat, 13 Jun 2020 13:29:45 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1592069376; bh=wBoIx5PTINX7xu9u/98rg3og+IdtNhrCUeYEueBMoQo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mN7Z/apGDHeJFzVjOdg4BJJZoVRynYKBTSl/4CwZgPFJyQq8d+e9nRivgA3sp4Rvs oWbaxAtsHneO+Kkb9bLZUxcCb7MhFqyGCFHsgfE6h7AgCsd68wdvKEmgscWWfxRodm ahrB1S5YORLTh7IUMh1BzOncSLI2JwdceYx6juP4= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05DHTYGU010036; Sat, 13 Jun 2020 17:29:36 +0000 In-Reply-To: <83v9ju3nbl.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F29.5EE50C62.0018, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S52nP7kP c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=FmLVqxAHNlbpg0cQT3cA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 Received-SPF: softfail client-ip=91.136.14.74; envelope-from=mattiase@acm.org; helo=mail102c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/13 13:29:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252192 Archived-At: 13 juni 2020 kl. 19.09 skrev Eli Zaretskii : > But the code you want to supplant explicitly does something different: Yes, which is part of the reason why it's being supplanted. > Of course, single-digit hex RGB specs are rarely if ever used these > days, AFAIK, so maybe this isn't a problem in practice. But still, I > wonder what could we lose here or break. This isn't going to be a problem in practice. > How about (tty-color-values "#12345")? does it contradict yours? No, it is an error that is (correctly) rejected by the new code in the = same way that #xyz is currently rejected. > You are changing the behavior, so get ready to hear bug reports, is > all I'm saying. That's fine, I'll be ready. It's impossible to fix bugs without changing behaviour, so if we want = the former, we have to allow for the latter, within bounds appropriate = for the situation. > Then color-values-from-color-spec, I guess. Thank you, but a smidgen too many 'color' in there. Would = color-values-from-spec do?