From: "Victor J. Orlikowski" <victor.j.orlikowski@alumni.duke.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Prevent ERC from sending spurious PART messages
Date: Thu, 30 Mar 2017 18:18:46 -0400 [thread overview]
Message-ID: <C2DAFDAA-33F6-4775-BB92-D84D2522665F@alumni.duke.edu> (raw)
In-Reply-To: <87tw6axw1e.fsf@linux-m68k.org>
Works for me. Glad to re-submit shortly.
Best,
Victor
--
Victor J. Orlikowski <> victor.j.orlikowski@alumni.duke.edu
> On Mar 30, 2017, at 6:02 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
>> On Mär 30 2017, "Victor J. Orlikowski" <victor.j.orlikowski@alumni.duke.edu> wrote:
>>
>> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
>> index 488404d..357d03c 100644
>> --- a/lisp/erc/erc.el
>> +++ b/lisp/erc/erc.el
>> @@ -6735,9 +6735,10 @@ This function should be on `erc-kill-server-hook'."
>> This function should be on `erc-kill-channel-hook'."
>> (when (erc-server-process-alive)
>> (let ((tgt (erc-default-target)))
>> - (erc-server-send (format "PART %s :%s" tgt
>> - (funcall erc-part-reason nil))
>> - nil tgt))))
>> + (unless (not tgt)
>
> (unless (not)) == (when)
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
next prev parent reply other threads:[~2017-03-30 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 19:41 [PATCH] Prevent ERC from sending spurious PART messages Victor J. Orlikowski
2017-03-30 22:02 ` Andreas Schwab
2017-03-30 22:18 ` Victor J. Orlikowski [this message]
2017-03-30 22:56 ` [PATCH] v2: " Victor J. Orlikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2DAFDAA-33F6-4775-BB92-D84D2522665F@alumni.duke.edu \
--to=victor.j.orlikowski@alumni.duke.edu \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).