From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Fri, 16 Jul 2021 23:12:00 -0400 Message-ID: References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40579"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 17 05:12:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4akr-000APc-My for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Jul 2021 05:12:41 +0200 Original-Received: from localhost ([::1]:59168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4akq-00052Z-9E for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Jul 2021 23:12:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4akF-0004NY-Se for emacs-devel@gnu.org; Fri, 16 Jul 2021 23:12:03 -0400 Original-Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:34457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4akE-0007l3-Bl for emacs-devel@gnu.org; Fri, 16 Jul 2021 23:12:03 -0400 Original-Received: by mail-qk1-x730.google.com with SMTP id r125so10795856qkf.1 for ; Fri, 16 Jul 2021 20:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nHHUGOZCMBQTGS1Hl96nexH8/NOvizhRY84w2z+iK+A=; b=aW+wtNJ+MxFV4iEPsRCVTqiRjWdL5GeFiL1NuR7VFRCSeUs//s+JTeGtf7aSTwjbCx SgKTx9VtMQ+ZUS1MUdW/do2RsFNKF4uPBu9pzsAgAOkU/TVr4PVJqvxSRT4LlPsasMWf hoGZBNibf+dDzG0z7AfzuuYpX3yrmwg9CIeUApUptgUyuCSBaoh502nx7KqwYwNify+b f/8ZgGRTybSkfvGQ8QxC0KedS1FXhfeQM15TaanQpfSQItgBxpLT8ul+jE89+h43Ve6A kH21IQvyJH5wCwdN3ylnxyQQg4t/UInW6QlwIHIGCVrmuBlYGEiHAh70JK7uvHspt43b sXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nHHUGOZCMBQTGS1Hl96nexH8/NOvizhRY84w2z+iK+A=; b=cAGUzJofNXyWPjtuQHfpx3yIWDMEbNYZhTF3vris1CplR65b0m+sQE8+4L/yGBSyZA LCK1FBChj/Z3d6+Fw3NSqmRyyubJ7t0MmutA6Tb+MIZodM9T1Ygnyv3/tIZAgfJR21Sb id/FY7K9ves8pJzPKlCWLEA+E47WFzFhWj7K1CCDnglauH1XyLlguFYKhozlfKiuSGPp fx5bG1iTWifjOtWYtOrRSAU1ajMhEeB5WE2ETHJTWhA9P7BD2S74+lO3BUOC6sX7f7un r147C349HyyP6Gz3C2xKUigJP2Yf0qrY42te+dKma4BEg9u+YJl3r3RupXXn+xsWj5EK f3rg== X-Gm-Message-State: AOAM533jQGVY2XA2E0YjxObcruAXNLOjA1j5OeoeNXPw05xPzzMcDd1J GECEeIH8pTKjdpanwqgenxk= X-Google-Smtp-Source: ABdhPJzTFLHDWd1XJ5Xyo/soBZWvfvoZXsc9+V8crCtVa3svyEnTG+O1dFehBdoC8SK6tLujYuu9Cw== X-Received: by 2002:a05:620a:1998:: with SMTP id bm24mr12737979qkb.319.1626491521356; Fri, 16 Jul 2021 20:12:01 -0700 (PDT) Original-Received: from ?IPv6:2601:98a:4200:9210:245f:fe46:1219:d972? ([2601:98a:4200:9210:245f:fe46:1219:d972]) by smtp.gmail.com with ESMTPSA id x20sm4770928qkp.15.2021.07.16.20.12.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jul 2021 20:12:00 -0700 (PDT) In-Reply-To: <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=casouri@gmail.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271325 Archived-At: > On Jul 16, 2021, at 10:23 PM, Cl=C3=A9ment Pit-Claudel = wrote: >=20 > On 7/16/21 10:05 PM, Yuan Fu wrote: >> My conclusion is that after-change-hook is pretty insignificant, and = the initial parse is a bit slow (on large files). >=20 > I have no idea if it makes sense, but: does the initial parse need to = be synchronous, or could you instead run the parsing in one thread, and = the rest of Emacs in another? (I'm talking about concurrent execution, = not cooperative threading). >=20 > In most cases there should be very limited contention, if at at all: = in large buffers most of Emacs' activity will be focused on the = (relatively few) characters around the gap, and most of the parser's = activity will be reading from the buffer at other positions. You do = need to be careful to not read the garbage data from the gap, but = otherwise seeing stale or even inconsistent data from the parser thread = shouldn't be an issue, since tree-sitter is supposed to be robust to bad = parses. >=20 > In fact, depending on how robust tree-sitter is, you might even be = able to do the concurrency-control optimistically (parse everything up = to close to the gap, check that the gap hasn't moved into the region = that you read, and then resume reading or rollback). >=20 > Alternatively, maybe you could even do a full parse with minimal = concurrency control: you'd make sure that the Emacs thread records not = just changes to the buffer text but also movements of the gap, and then = you could use that list of changes for the next parse? Another way I thought about is to only =E2=80=9Cexpose=E2=80=9D the = portion of buffer from BOB to some point to tree-sitter. And when a user = asks for a parse tree, he also specifies to which point of the buffer he = needs the parse tree for. For example, for fortification, jit-lock only = needs the tree up to the end of the visible window. And for structure = editing, asking for the portion up to window-end + a few thousand = characters might be enough. However this heuristic could have problems = in practice. (Maybe a giant comment section of thousands of characters = follows, and instead of jumping to the end of it, we wrongly jump to = middle of that comment section, because tree-sitter only =E2=80=9Csees=E2=80= =9D to that point.) So I don=E2=80=99t know if it=E2=80=99s a good idea. >=20 > Anyway, thanks for working on this! >=20 I figure that this is low-tech enough that an amateur like me could = possibly do it ;-) Yuan