From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package xeft.el Date: Tue, 10 Jan 2023 02:57:14 -0800 Message-ID: References: <64A01ADD-E757-40F5-A5C3-518BB8BE9A41@gmail.com> <659E0780-5694-4B43-9845-AF1C0E2F7ECE@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20264"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 10 12:11:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFCX9-000587-Qf for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Jan 2023 12:11:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFCJs-0007Lk-0e; Tue, 10 Jan 2023 05:57:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFCJk-0007JE-Eg for emacs-devel@gnu.org; Tue, 10 Jan 2023 05:57:22 -0500 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFCJi-0006ob-4x for emacs-devel@gnu.org; Tue, 10 Jan 2023 05:57:20 -0500 Original-Received: by mail-pj1-x1032.google.com with SMTP id m7-20020a17090a730700b00225ebb9cd01so16020822pjk.3 for ; Tue, 10 Jan 2023 02:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TOKLcriuhusVOHbFAi9VDFoMrxF0uB9v7W5pun5d3Ak=; b=DJ4eInUEw1qzH7jIg3p2iMZh5K/Eo6Te91KhBKzemyO/aVJcS1U1bm9mEeNakc8htM kkFjQLZDUyx14fdwqTVjHIExVOnqPn2jilOsMwITQR58j1czGsQohcyW45ahzhlhMQLp U4NeVJ/DnK9OFI5d5WnDc7MDvq6ejmtbdMSAo/rGwwwIYLMJMayL6vAAs200enWG6ckF MQLvLmHL+eTtTN9cQ+Ne3us2d71g79pcfIvo6hpk95EK7liHeRUePbngHPTS98/9ON5I nMrGjEQMC4dc1pSbmruUHwXU0Gl7HugqrjqslGL+IaxAS2f8OBcBEa4KsESywDthCuwb CREg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TOKLcriuhusVOHbFAi9VDFoMrxF0uB9v7W5pun5d3Ak=; b=UabmXwLlrkgvT3zyd/y42uKaM6HMCGD+sZodWNK2vaGJ5dHmO3GMgMCaM1Tjof+wgx dmxWrF9KisGWcIKAXZr6yxZgBee22uwxanKzWNwo5dpt59lB8L7vsK+605OQ4DkhSmtH fedbQVA7VuScu7tCgr0b0mpOuvqJnv10l7CJdD/k8qzXBlf67lIZg8KYDKcDIoDk4fJ4 gwyuGukaKtK01gYe8piDz1msFOUWUeabdp/wfTrg60ZxTyfkouEXvFW0DZUH53L39tsu hR4fECV8wWuT85f+iyKtbkh9MF6UsCvHCEIvrDXALW7FQq1OvAI8zFi0Ae+g6UgHmYOf Co7Q== X-Gm-Message-State: AFqh2ko5PIFVTaYEs3O4QHIEqoN4/gqGUl9ayqFKt32CHoVM/U+nxgVT oX+hxJN6NYQdh9nDnJJcBWM= X-Google-Smtp-Source: AMrXdXvLhxKa6r6HjAfgBRYAwT/Zr6gzzFBX75PMdV2Qn9fR5bANoh23jeuMmCKQK6IDBtOcmxK3eA== X-Received: by 2002:a17:903:1209:b0:193:2303:c9e5 with SMTP id l9-20020a170903120900b001932303c9e5mr13227783plh.20.1673348236117; Tue, 10 Jan 2023 02:57:16 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j1-20020a170902c3c100b0018853416bbcsm7912924plj.7.2023.01.10.02.57.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jan 2023 02:57:15 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=casouri@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302312 Archived-At: > On Jan 6, 2023, at 8:21 AM, Stefan Monnier = wrote: >=20 >> Yeah I can do that. The download feature is probably = over-engineering >> for not much benefit :-) >=20 > It's beneficial for those who don't have a local C/C++ compiler. > With the requirements of native compilation, this may become less of = an > issue, but still, it's something that's been requested fairly often > (mostly by package maintainers rather than by users, admittedly, but > still). >=20 >>> Other details I saw along the way: >>> - You claim you have precompiled packages for GNU/Linux but that's = only >>> true for amd64, which is only a particular subset of GNU/Linux >>> (most of my GNU/Linux machines (i386, armhf, arm64) are outside of >>> that subset, for example). >> That=E2=80=99s true, probably better to not have the download = feature. >=20 > At the same time amd4 covers probably the vast majority of users. >=20 > Maybe elpa.gnu.org could be used to host precompiled binaries. > Our Free Software ideals tell us we should expose the source code as > much as possible so I think "download binary" should be an alternative > to "compile the source" rather than to "download the source", so the > first point is to include the source code in the ELPA package. >=20 > We may even be able to make elpa.gnu.org generate precompiled binaries > for armhf, i386, and arm64 (it's fairly easy to install those > cross-compilation tools under Debian). But this won't happen until > someone writes the code for that. >=20 >>> - Your source code includes `emacs-module.h` which should not be >>> necessary because that file is distributed with Emacs (the way `pq` >>> finds it is not ideal, but this might be a good opportunity to look >>> at improving the situation and providing a standardized way for >>> ELisp packages to find that file). >>=20 >> Is it included in the distributed Emacs? >=20 > Yes. >=20 >> I thought you would need the source of Emacs to access that file. >=20 > No, `make install` copies it to a "sane" place. > But I don't (yet?) know how to reliably find that place from the = running Emacs. Even if you can, I=E2=80=99d say ideally you want to be able to compile = a dynamic module without a running Emacs. I: - added copyright notice to xapian-lite.cc - added xapian-lite.cc (and friends) to the source repository of xeft, = so the user can compile the dynamic module (xapian-lite) without = downloading the source of it. - didn=E2=80=99t do anything about emacs-module.h. - changed the wording of some prompts of the compile/download process Yuan=