From: Adrian Robert <adrian.b.robert@gmail.com>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: Dan Nicolaescu <dann@ics.uci.edu>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change)
Date: Mon, 4 Aug 2008 12:11:31 -0400 [thread overview]
Message-ID: <C028FA74-4691-419D-8C17-578A2FD558F1@gmail.com> (raw)
In-Reply-To: <D6F7ABC9-C194-4964-9BCD-6FB94AD351A7@gmail.com>
On Aug 3, 2008, at 12:41 PM, Adrian Robert wrote:
>
> On Aug 3, 2008, at 11:59 AM, Dan Nicolaescu wrote:
>
>> This code in emacs.c is not right:
>>
>> #if defined (NS_IMPL_COCOA)
>> if (!initialized)
>> unexec_init_emacs_zone ();
>> #endif
>>
>> it should be done on all MacOSX configs.
>
> I've been looking at this, and made a diff of before and after
> remove-carbon to see what else might have been affected, since I
> never realized that the undef MAC_OSX wasn't working.
OK, the above should be fixed. (DARWIN_OS is set in darwin.h and used
to indicate on OS X or pure Darwin; unexmacosx.c should be at some
point renamed to unexdarwin.c.)
I've also gone through the removal diff and wanted to ask about the
bit below since it may be something that all terms should do:
Index: atimer.c
===================================================================
RCS file: /sources/emacs/emacs/src/atimer.c,v
retrieving revision 1.28
retrieving revision 1.27
diff -u -r1.28 -r1.27
--- atimer.c 27 Jul 2008 18:24:40 -0000 1.28
+++ atimer.c 14 May 2008 07:49:08 -0000 1.27
@@ -368,7 +368,9 @@
t = atimers;
atimers = atimers->next;
+#ifndef MAC_OSX
t->fn (t);
+#endif
if (t->type == ATIMER_CONTINUOUS)
{
@@ -380,6 +382,10 @@
t->next = free_atimers;
free_atimers = t;
}
+#ifdef MAC_OSX
+ /* Fix for Ctrl-G. Perhaps this should apply to all platforms.
*/
+ t->fn (t);
+#endif
EMACS_GET_TIME (now);
}
next prev parent reply other threads:[~2008-08-04 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu>
[not found] ` <E465D318-490F-44DB-B8E2-04227EE9498A@gmail.com>
[not found] ` <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu>
[not found] ` <B6D54F89-C459-46DD-BEEA-DB723F7A725E@gmail.com>
[not found] ` <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu>
2008-08-03 16:41 ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Adrian Robert
2008-08-04 0:23 ` YAMAMOTO Mitsuharu
2008-08-04 1:20 ` fixing non-NS darwin Dan Nicolaescu
2008-08-04 2:03 ` YAMAMOTO Mitsuharu
2008-08-04 2:26 ` Dan Nicolaescu
2008-08-04 3:49 ` YAMAMOTO Mitsuharu
2008-08-04 4:02 ` Dan Nicolaescu
2008-08-04 9:08 ` Thien-Thi Nguyen
2008-08-04 11:53 ` Dan Nicolaescu
2008-08-04 1:11 ` Dan Nicolaescu
2008-08-04 16:11 ` Adrian Robert [this message]
2008-08-04 17:31 ` Dan Nicolaescu
2008-08-05 9:21 ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) YAMAMOTO Mitsuharu
2008-08-04 13:59 ` Adrian Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C028FA74-4691-419D-8C17-578A2FD558F1@gmail.com \
--to=adrian.b.robert@gmail.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).