From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: highlight failed part of isearch input Date: Tue, 24 Jul 2007 10:25:56 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1185297999 21630 80.91.229.12 (24 Jul 2007 17:26:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Jul 2007 17:26:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: , "Juri Linkov" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 24 19:26:38 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDO9d-0006bS-0B for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 19:26:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDO9c-0002NJ-By for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 13:26:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDO9Z-0002NE-Ch for emacs-devel@gnu.org; Tue, 24 Jul 2007 13:26:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDO9X-0002Mz-Vv for emacs-devel@gnu.org; Tue, 24 Jul 2007 13:26:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDO9X-0002Mw-Oy for emacs-devel@gnu.org; Tue, 24 Jul 2007 13:26:31 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IDO9W-0001dr-J0; Tue, 24 Jul 2007 13:26:30 -0400 Original-Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l6OHQRcd016851; Tue, 24 Jul 2007 11:26:27 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id l6NC3nSg015905; Tue, 24 Jul 2007 11:26:26 -0600 Original-Received: from dhcp-amer-whq-csvpn-gw3-141-144-81-254.vpn.oracle.com by acsmt351.oracle.com with ESMTP id 3063938551185297959; Tue, 24 Jul 2007 10:25:59 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75469 Archived-At: > I like this proposal but there is a problem in the patch: > > (when (string-match " +$" m) > (propertize (substring m (match-beginning 0)) 'face > 'trailing-whitespace)) > > This is a no-op. > > Yes, if it is used for effect. There was no effect. Maybe that's what you meant; I'm not sure. That code was a mistake. The intention was to change the face in the string `m', not in a copy. For instance, `put-text-property' could have been used instead of `propertize'. > But maybe it is good to remove this code because the > failed trailing whitespace is highlighted in the new face > isearch-failed. > > I don't entirely understand. What change are you proposing? I think Juri meant that instead of using two different faces, one for general failure and one for trailing whitespace, the former is enough (trailing whitespace is subsumed by search failure).