From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: highlight failed part of isearch input Date: Mon, 23 Jul 2007 15:37:55 -0700 Message-ID: References: <87k5sqerle.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1185230392 7224 80.91.229.12 (23 Jul 2007 22:39:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2007 22:39:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Juri Linkov" , Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 24 00:39:51 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ID6ZC-0000Uz-7p for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 00:39:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ID6ZB-0003HG-Ox for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2007 18:39:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ID6Z4-0003F5-L3 for emacs-devel@gnu.org; Mon, 23 Jul 2007 18:39:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ID6Z2-0003Eg-Tp for emacs-devel@gnu.org; Mon, 23 Jul 2007 18:39:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ID6Z2-0003Ed-Qg for emacs-devel@gnu.org; Mon, 23 Jul 2007 18:39:40 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ID6Z1-0000LP-B8; Mon, 23 Jul 2007 18:39:39 -0400 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l6NMdacC017572; Mon, 23 Jul 2007 16:39:36 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id l6N8jHx8008149; Mon, 23 Jul 2007 16:39:36 -0600 Original-Received: from dhcp-4op11-4op12-west-130-35-178-179.us.oracle.com by acsmt351.oracle.com with ESMTP id 3062781971185230277; Mon, 23 Jul 2007 15:37:57 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-reply-to: <87k5sqerle.fsf@jurta.org> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75421 Archived-At: > > It seems that only the tweaks that came out of the > > secondary discussion in this thread were applied; the > > original proposal was not. Here is the diff. > > > > Would someone please apply that patch, and ack? > > I like this proposal but there is a problem in the patch: > > (when (string-match " +$" m) > (propertize (substring m (match-beginning 0)) 'face > 'trailing-whitespace)) > > This is a no-op. But maybe it is good to remove this code because the > failed trailing whitespace is highlighted in the new face isearch-failed. > We could change its background to more strong color, e.g. to something > like is used in Firefox failed search, so failed space will be > more visible. Good catch. We need to change the face of the pertinent part of `m' itself, not just a copy. Thx. The face to use for that is `trailing-whitespace', no?