RE: find-file-read-args: cursor's file as default in Dired

["Drew Adams" <drew.adams@oracle.com>]

> >>     Here's what it should be, so that `M-n' with `C-x C-f' gives
> >>     you the file of the cursor in Dired mode:
> >>
> >> That is a good feature.  Would you please send a patch and change log
> >> entry, and text for etc/NEWS?
> >
> > ----------------8<----------------------------------
> >
> > 2007-07-10  Drew Adams  <drew.adams@oracle.com>
> >
> >       *files.el (find-file-read-args): Default in Dired mode is
> >       cursor's file.
>
> `dired-get-file-for-visit' causes `C-x C-f' to fail when typed on
> a non-file line in the dired buffer.

Good catch. How about one of these instead? I prefer the second; it's
simpler and quicker (`minibuffer-message' pauses).

;; This one gives you error feedback.
(defun find-file-read-args (prompt mustmatch)
  (list (let ((find-file-default
               (if (eq major-mode 'dired-mode)
                   (let ((this-file
                          (condition-case err
                              (dired-get-file-for-visit)
                            (error
                             (and (save-selected-window
                                    (select-window (minibuffer-window))
                                    (minibuffer-message
                                     (error-message-string err))))))))
                     (and this-file (abbreviate-file-name this-file)))
                 (and buffer-file-name (abbreviate-file-name
                                        buffer-file-name)))))
          (minibuffer-with-setup-hook
              (lambda () (setq minibuffer-default find-file-default))
            (read-file-name prompt nil default-directory mustmatch)))
        t))

;; This one just gets on with it.
(defun find-file-read-args (prompt mustmatch)
  (list (let ((find-file-default
               (if (eq major-mode 'dired-mode)
                   (let ((this-file (condition-case nil
                                        (dired-get-file-for-visit)
                                      (error nil))))
                     (if this-file
                         (abbreviate-file-name this-file)
                       (and buffer-file-name (abbreviate-file-name
                                              buffer-file-name))))
                 (and buffer-file-name (abbreviate-file-name
                                        buffer-file-name)))))
          (minibuffer-with-setup-hook
              (lambda () (setq minibuffer-default find-file-default))
            (read-file-name prompt nil default-directory mustmatch)))
        t))