unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: <rms@gnu.org>
Cc: eliz@gnu.org, hannes@saeurebad.de, kifer@cs.sunysb.edu,
	emacs-devel@gnu.org
Subject: RE: Problems with setting face attributes for specific frames
Date: Tue, 2 Oct 2007 08:09:19 -0700	[thread overview]
Message-ID: <BNELLINCGFJLDJIKDGACGEEPCDAA.drew.adams@oracle.com> (raw)
In-Reply-To: <E1IcYVA-0000vJ-FO@fencepost.gnu.org>

>     >     I don't understand all of what you're proposing or what the
>     >     problem is that you're fixing. I think you're proposing removing
>     >     the FRAME arg from `set-face-attribute' (perhaps among other
>     >     changes). Is that correct?
>     >
>     > Yes.
>
>     OK, but I still don't understand the problem that you're
>     fixing. Could you perhaps summarize it?
>
> If we get rid of using `set-face-attribute' for specific frames, the
> resulting simplification would make it possible to fix the handling of
> changes in background mode due to setting the background color.

AFAICT, I do not currently change a face attribute for a single frame, but
it sounds like a reasonable thing to want to do. Is getting rid of that
possibility really necessary to be able to handle "changes in background
mode due to setting the background color"?

I still don't understand what that problem is, BTW. In your description of
it in this thread, you say that it has to do with `set-background-color'
calling `frame-set-background'. Why does doing that affect the frame
background mode? And what does changing the frame background (with or
without the background mode) have to do with changing an attribute of an
individual face for that frame?

Conceptually, at least, those would seem to be separate things. Perhaps the
problem is that they are not separate in the implementation? You say that
you can alternatively solve this problem by keeping "user-specified
single-frame face attributes separate from the actual face attributes
deduced..." If the former are interfering with the frame background mode,
then that sounds like a better approach than simply getting rid of them.

To me, they sound like a useful feature, perhaps even more useful than the
frame-background-mode, which is anyway problematic wrt what constitutes
"light" and "dark" etc.

In any case, as I say, I don't use that feature today. The more important
problem you would create for me (by your other proposal) would be to get rid
of the ability to change a face attribute globally (for all frames at once).
What is the reason for that proposal? AFAICT, you gave no reason; you just
said you are thinking of making that change.

  reply	other threads:[~2007-10-02 15:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 14:38 [BUG] Dark/bright face detection problem Johannes Weiner
2007-09-28 15:46 ` Johannes Weiner
2007-09-29 16:10   ` Richard Stallman
2007-09-29 21:20     ` Johannes Weiner
2007-09-29 21:32       ` Johannes Weiner
     [not found]         ` <E1IbyK0-0005DQ-DU@fencepost.gnu.org>
2007-09-30 16:28           ` Problems with setting face attributes for specific frames Eli Zaretskii
2007-10-01 17:40             ` Richard Stallman
2007-09-30 23:54           ` Drew Adams
2007-10-01 17:40             ` Richard Stallman
2007-10-01 18:17               ` Drew Adams
2007-10-02  3:32                 ` Richard Stallman
2007-10-02 15:09                   ` Drew Adams [this message]
2007-10-02 22:00                     ` Richard Stallman
2007-10-01 18:45               ` Stephen J. Turnbull
2007-10-02  3:32                 ` Richard Stallman
2007-09-29 16:21   ` [BUG] Dark/bright face detection problem Dan Nicolaescu
2007-09-29 15:52 ` Eli Zaretskii
2007-09-29 16:16   ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BNELLINCGFJLDJIKDGACGEEPCDAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=hannes@saeurebad.de \
    --cc=kifer@cs.sunysb.edu \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).