unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs-devel@gnu.org
Subject: RE: should fset 'symbol get an undefined function warning?
Date: Tue, 30 Oct 2007 15:39:58 -0700	[thread overview]
Message-ID: <BNELLINCGFJLDJIKDGACEEFACEAA.drew.adams@oracle.com> (raw)
In-Reply-To: <jwv8x5kuuyq.fsf-monnier+emacs@gnu.org>

> > `defalias' might be better to use in this context, but it
> > should still be good to not issue that warning for `fset'.
> > (I'm not saying anyone has disagreed with that.)
>
> I disagree: `fset' is meant to *change* the function-slot
> of a symbol, not to initialize it.  So it's use shouldn't be treated by
> the byte-compiler as a declaration.  Insted, the byute-compiler should
> complain about the use of `fset' on an unknown function similarly to the
> use of `set(q)' on an unknown variable.

Good point. I'm convinced.

Was there an opposing consideration that led you to say "Could be" at first,
or was that before this point occurred to you?

  reply	other threads:[~2007-10-30 22:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30  5:14 should fset 'symbol get an undefined function warning? Dan Nicolaescu
2007-10-30 18:58 ` Stefan Monnier
2007-10-30 20:47   ` Dan Nicolaescu
2007-10-30 21:05     ` Drew Adams
2007-10-30 21:59       ` Stefan Monnier
2007-10-30 22:39         ` Drew Adams [this message]
2007-10-31  0:55           ` Stefan Monnier
2007-10-31  0:09 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BNELLINCGFJLDJIKDGACEEFACEAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).