From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: highlight current line when Emacs is idle Date: Fri, 13 Jul 2007 14:22:31 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1184361798 21904 80.91.229.12 (13 Jul 2007 21:23:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 Jul 2007 21:23:18 +0000 (UTC) Cc: Emacs-Devel To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 13 23:23:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I9Sbc-0006xb-O2 for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2007 23:23:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I9Sbc-0006kg-4m for ged-emacs-devel@m.gmane.org; Fri, 13 Jul 2007 17:23:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I9SbY-0006kJ-A5 for emacs-devel@gnu.org; Fri, 13 Jul 2007 17:23:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I9SbW-0006k7-SE for emacs-devel@gnu.org; Fri, 13 Jul 2007 17:23:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I9SbW-0006k3-PX for emacs-devel@gnu.org; Fri, 13 Jul 2007 17:23:10 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I9SbW-00025F-CF for emacs-devel@gnu.org; Fri, 13 Jul 2007 17:23:10 -0400 Original-Received: from rgmgw2.us.oracle.com (rgmgw2.us.oracle.com [138.1.186.111]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l6DLN5ST032723; Fri, 13 Jul 2007 15:23:06 -0600 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by rgmgw2.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l6DEM7Va016679; Fri, 13 Jul 2007 15:23:05 -0600 Original-Received: from dhcp-amer-csvpn-gw2-141-144-72-53.vpn.oracle.com by acsmt351.oracle.com with ESMTP id 3038565901184361755; Fri, 13 Jul 2007 14:22:35 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 Importance: Normal X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:74738 Archived-At: > > (defface hl-line > > ! '((((class color) (min-colors 88) (background light)) :background > > "SlateGray3") > > ! (t :inherit highlight)) > > I think it is generally an error for a face to inherit in some > cases and not in others. > > I.e. the above should be > > (defface hl-line > '((default :inherit highlight) > (((class color) (min-colors 88) (background light)) > :background "SlateGray3")) You're probably right. And we probably need better default behavior for non-light-bg color displays too. (1) Ignorance - I wasn't aware of the guideline involving :inherit, and I haven't used `default' before. (2) Laziness - I threw together the face definition quickly to provide something for the non-light background cases. All I use, myself, is the light-bg case, so the rest is suspect. Suggestions welcome. Likewise, for other faces. It's easier for people who use dark backgrounds to propose something reasonable - likewise for non-color.