From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: patch for buff-menu.el enhancements Date: Tue, 10 Jul 2007 10:25:07 -0700 Message-ID: References: <200707101602.l6AG2H2p005213@jane.dms.auburn.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1184088482 24040 80.91.229.12 (10 Jul 2007 17:28:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 Jul 2007 17:28:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Luc Teirlinck" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 19:27:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I8JVG-00077H-P8 for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2007 19:27:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I8JVG-0000xc-5b for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2007 13:27:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I8JUb-0000Vt-5D for emacs-devel@gnu.org; Tue, 10 Jul 2007 13:27:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I8JUa-0000VC-8y for emacs-devel@gnu.org; Tue, 10 Jul 2007 13:27:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I8JUa-0000V4-1W for emacs-devel@gnu.org; Tue, 10 Jul 2007 13:27:16 -0400 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I8JUZ-0008S7-KE for emacs-devel@gnu.org; Tue, 10 Jul 2007 13:27:15 -0400 Original-Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l6AHRACO025613; Tue, 10 Jul 2007 12:27:10 -0500 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l6AH6rUi002196; Tue, 10 Jul 2007 11:27:09 -0600 Original-Received: from dhcp-amer-csvpn-gw2-141-144-73-85.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3026538921184088311; Tue, 10 Jul 2007 10:25:11 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <200707101602.l6AG2H2p005213@jane.dms.auburn.edu> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:74571 Archived-At: > ! If `Buffer-menu-use-header-line' is non-nil, you can click a > ! column heading to sort by that column. > > _Without_ your patch, you can do that even if > `Buffer-menu-use-header-line' is nil. Disabling the feature in that > case is definitely not improvement; in fact I consider it a bug. I disabled nothing of the kind. The doc string was incorrect, sorry. Here's the correction: Please remove the phrase "If `Buffer-menu-use-header-line' is non-nil, ". Thanks for noticing that. > I do not understand _why_ you want to reimplement the existing feature, > which seems to work perfectly fine to me and also plays well with > autoreverting the buffer menu. (I did not check if your > reimplementation does.) Please try it. I don't think I did what you suggest. There is no problem reverting the buffer. Reverting changes nothing; the current sort is maintained. FWIW, I proposed essentially this same patch back in 2004. I updated it for the latest version of buff-menu.el. See, for example, these threads: * 2004/10/16, "buff-menu.el - minor enhancement to sort columns up or down" * 2004/11/19, "buff-menu.el header line" * 2005/11/28, "Buffer listing in multiple frames/ttys" (related wrt sorting) The only changes from vanilla Emacs wrt column sorting that my patch makes are those I mentioned, in particular, (1) being able to sort in either direction, (2) indicating the current sort column and sort direction with an overline/underline of the column heading, and (3) being able to also sort column `CRM' (one direction of which is the default sort). For those who use Windows Explorer, you will recognize this click-column-header sorting; you probably use it many times a day. IMO, it is one of the most useful features of Windows Explorer. I think we should do the same thing for Dired.