From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Thu, 29 Jul 2021 11:57:56 -0400 Message-ID: References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> <834kcetmly.fsf@gnu.org> <831r7itjc8.fsf@gnu.org> <24808548-23F4-4068-877E-37C7190A02B0@gmail.com> <83wnpas1q7.fsf@gnu.org> <83k0l9rvf5.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37537"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , Stephen Leake , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 29 17:58:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m98Qk-0009Sk-5Z for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 17:58:42 +0200 Original-Received: from localhost ([::1]:51080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m98Qj-0007W8-2L for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 11:58:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98Q5-0006nY-C9 for emacs-devel@gnu.org; Thu, 29 Jul 2021 11:58:01 -0400 Original-Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:39684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m98Q3-0002zd-I8; Thu, 29 Jul 2021 11:58:01 -0400 Original-Received: by mail-qt1-x829.google.com with SMTP id d2so4258288qto.6; Thu, 29 Jul 2021 08:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=74fZIGlZ5lBkqI+dH2OlX9r5c6B9cOPbmmdU5cOjoDM=; b=GzD0Ky045g6k9B/hCb94DuHSYyBRVJUJKFWEfcFjTXkYnxXGdCHQEZZjo2DNCtTQep ovYIK0fsGMWyGeW5n/Fyw1hHRqvhnn1DfcVjvnlMIvKp+tX8uqI4XknvEeOqrvwmeQME vvz2MZmb7tKdH0sC7u1uygVpQTYuWrSGcIunlCJPoxqElxmdrt3uklNMg8jA82lpMsNu syMdCO4fvlT0zb9SGdhqoWw8TzKBDMq+WkNCUCX/2PslCRvZw1fxmnQ2B/d9t0NfZAIt nOlmI2Ryokocw181Vq8Vwg2/JRx2HRn2cOvqkCQ1QSjPYGj4e4IYjaCR7B60haqlQ2Qk XkLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=74fZIGlZ5lBkqI+dH2OlX9r5c6B9cOPbmmdU5cOjoDM=; b=hPDjCg2BNGDLnb8OmnmxawB9W66CcJdi5KcGr1NBSqIICMh0JwHxbqsNS67fz1Rw85 0lSIgKNIxmePR/LlznqssBZzgnJZEYJteqiLbq/rwK/nPFwUhLLhRMknHdbkWNkykgTQ 7oSbQrfCWIc4YguyPd46WbnJVMFZdxHxml2gFNQGnYYusHwvGxuGhEUKuYu8ZHCsZc7S KR/PexjQhgt2+RYFyw52IcLQBPEt++H7uRN2sXmE4hywYaF1Dmh/LMwUzuo4lfMg8j9x UwoD/OTV3UwoJVCovoM1VdRWocQW1vB3qDhjZm1sLNp0xYynLGljFiWic1qWkqNcQuz+ s3Kw== X-Gm-Message-State: AOAM531f/SYWBxiZA25BU0cg23MUio92qRN54aodzlAyaKjoA3GC+JBG H9ERJ+ODKrNV/OnDQt7Fs+7zkB717rv8Pw== X-Google-Smtp-Source: ABdhPJxmzFeCTUEbSifka54ykEatYIHNWX6O3ediOV3mPKBpAJC5lCmOf5Um6FbROZ/E0JRHhHlWmA== X-Received: by 2002:a05:622a:14a:: with SMTP id v10mr4830389qtw.383.1627574278002; Thu, 29 Jul 2021 08:57:58 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com (2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com. [2603:7080:302:635e:540d:2222:3fe9:1314]) by smtp.gmail.com with ESMTPSA id k17sm1352521qta.6.2021.07.29.08.57.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 08:57:57 -0700 (PDT) In-Reply-To: <83k0l9rvf5.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::829; envelope-from=casouri@gmail.com; helo=mail-qt1-x829.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271791 Archived-At: > On Jul 29, 2021, at 11:28 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 29 Jul 2021 10:35:10 -0400 >> Cc: Stephen Leake , >> Cl=C3=A9ment Pit-Claudel , >> Stefan Monnier , >> emacs-devel@gnu.org >>=20 >>> We don't need to know. The Lisp program which needs to handle this >>> situation will have to figure out what is right in that case, = "right" >>> in the sense that it produces the desired results after = communicating >>> the changes to TS. >>=20 >> The difficulty is that what tree-sitter sees must be consistent. If = Emacs updates tree-sitter with option 1 and lisp later choose option 2, = the content that tree-sitter sees is not consistent. >=20 > If that happens, it means the Lisp program which does that has a bug > that needs to be fixed. >=20 >> Anyway, I found a way that avoids this issue: the bounds of = tree-sitter=E2=80=99s visible region never changes, and the next time = when lisp narrows to a different region, we update tree-sitter=E2=80=99s = bound to match that of the narrowing. Here is the latest patch. If the = code is not entirely straightforward, I=E2=80=99m happy to add more = comment to explain it. >=20 > I'm not sure we should do this, because it means we second-guess what > the Lisp program calling TS intends to do. Why should we do that, > instead of leaving it to the Lisp program to DTRT? And what happens > if our guess is wrong? I don=E2=80=99t think the current implementation guesses anything. Let = me turn around and ask you what is TRT: if the buffer is xxxAAAxxx, and = lisp narrows to AAA and creates a parser, parser sees AAA; now widen, = user inserts BBB in front of AAA, what do we tell tree-sitter? Nothing = changed, or BBB inserted at the beginning? To where should lisp narrow? = BBBAAA, or AAA, or BBB? Yuan=