From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char. Date: Thu, 19 Mar 2015 10:29:34 +0530 Message-ID: References: <20150318194629.7043.70347@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----ACUJP4HVJ250FX9OQK0MCUT3O7NCYO" Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1426741224 16250 80.91.229.3 (19 Mar 2015 05:00:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Mar 2015 05:00:24 +0000 (UTC) To: Stefan Monnier ,emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 19 06:00:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYSZ7-0006ER-Bp for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 06:00:17 +0100 Original-Received: from localhost ([::1]:37091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYSZ6-0005eU-Pu for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 01:00:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYSYp-0005dr-3G for emacs-devel@gnu.org; Thu, 19 Mar 2015 01:00:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYSYj-0004ec-Vn for emacs-devel@gnu.org; Thu, 19 Mar 2015 00:59:59 -0400 Original-Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:33456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYSYj-0004bT-NJ for emacs-devel@gnu.org; Thu, 19 Mar 2015 00:59:53 -0400 Original-Received: by wgbcc7 with SMTP id cc7so52296586wgb.0 for ; Wed, 18 Mar 2015 21:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:from:date:to:message-id; bh=5fa7sdULRxoOHr+Jovqi1L04ee/UgGmYv4lzLnEV96Q=; b=Dg70urXI4kAfDzdVKmt3/TfoHTFJqsEZ3IConY8GOwD+jsNMKYpMxbK+m9gpXMiSoI yN2nmAkTDJspyQHMF4GupoSORCxTyG7U1oS9Rdloje7dUyfKO6L0d33+6CplPKQ0pP/I ypBG/hSEvnhCMsdG9gg4lwljWvC4YjIiEjZOrUdoATzjp4I+FEcgQfsd+Rl/9YHDTGAR cZ8SBjsV62R8Vt0djpc7Bgg6/18oWglp1+d/epN7/ulct348WqN9/acCjDAlVxAfLgF9 UeR1MGbNCGiMEjx2dMsdP0MxMG+O9VnTY8H5Eh7+SFFGoJPuzWdHPTkM2d0/eWLPElke eKOQ== X-Received: by 10.194.60.173 with SMTP id i13mr145716327wjr.124.1426741191573; Wed, 18 Mar 2015 21:59:51 -0700 (PDT) Original-Received: from android-7e032712659b285e.lan ([117.201.92.43]) by mx.google.com with ESMTPSA id g5sm319799wjr.19.2015.03.18.21.59.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2015 21:59:50 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184008 Archived-At: ------ACUJP4HVJ250FX9OQK0MCUT3O7NCYO Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Sorry for that, I'll send a patch soon. On 19 March 2015 8:48:04 am IST, Stefan Monnier wrote: >> * lisp/leim/quail/hangul.el >> * lisp/progmodes/cperl-mode.el: Use delete-char instead of >> delete-backward-char, fixes compilation warnings. > >The above doesn't use the right syntax. The right syntax looks like > > * (): blabla. > >IOW you need to add the function names. >Please re-read >https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs > >> @@ -2588,7 +2588,7 @@ Will untabify if >`cperl-electric-backspace-untabify' is non-nil." >> (delete-region (point) p)) >> (if cperl-electric-backspace-untabify >> (backward-delete-char-untabify arg) >> - (delete-backward-char arg))))) >> + (delete-char (- arg)))))) > >This doesn't look right: I think here we do want to run >delete-backward-char since this is part of a command which basically >extends the normal binding of DEL which is delete-backward-char. >Maybe we should call it interactively, tho. > > > Stefan -- Sent from my Android device with K-9 Mail. Please excuse my brevity. ------ACUJP4HVJ250FX9OQK0MCUT3O7NCYO Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Sorry for that, I'll send a patch soon.

On 19 March 2015 8:48:04 am IST, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
     * lisp/leim/quail/hangul.el
     * lisp/progmodes/cperl-mode.el: Use delete-char instead of
     delete-backward-char, fixes compilation warnings.

The above doesn't use the right syntax.  The right syntax looks like

  * <filename> (<functionname>): blabla.

IOW you need to add the function names.
Please re-read https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

 @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is non-nil."
     (delete-region (point) p))
        (if
cperl-electric-backspace-untabify
     (backward-delete-char-untabify arg)
 - (delete-backward-char arg)))))
 + (delete-char (- arg))))))

This doesn't look right: I think here we do want to run
delete-backward-char since this is part of a command which basically
extends the normal binding of DEL which is delete-backward-char.
Maybe we should call it interactively, tho.


        Stefan

--
Sent from my Android device with K-9 Mail. Please excuse my brevity. ------ACUJP4HVJ250FX9OQK0MCUT3O7NCYO--