From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: All platforms fail with Unicode in menus. Date: Sat, 28 Aug 2004 09:42:00 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <412E2C34.8070905@swipnet.se> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1093679032 11267 80.91.224.253 (28 Aug 2004 07:43:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 Aug 2004 07:43:52 +0000 (UTC) Cc: reiner.steib@gmx.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 28 09:43:40 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C0xsC-0004Z4-00 for ; Sat, 28 Aug 2004 09:43:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C0xwt-0000Vg-OV for ged-emacs-devel@m.gmane.org; Sat, 28 Aug 2004 03:48:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C0xwg-0000Va-JH for emacs-devel@gnu.org; Sat, 28 Aug 2004 03:48:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C0xwd-0000VN-Pl for emacs-devel@gnu.org; Sat, 28 Aug 2004 03:48:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C0xwd-0000VK-HT for emacs-devel@gnu.org; Sat, 28 Aug 2004 03:48:15 -0400 Original-Received: from [195.54.107.70] (helo=mxfep01.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C0xrS-0002oL-LD; Sat, 28 Aug 2004 03:42:55 -0400 Original-Received: from coolsville.localdomain ([213.115.26.74] [213.115.26.74]) by mxfep01.bredband.com with ESMTP id <20040828074252.YPJD5206.mxfep01.bredband.com@coolsville.localdomain>; Sat, 28 Aug 2004 09:42:52 +0200 In-Reply-To: Original-To: David Kastrup X-Mailer: Apple Mail (2.619) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26589 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26589 > >> + inhibit_garbage_collection (); > >> Can someone that knows ENCODE_UTF_8 and garbage collection well >> comment on this patch? > > I don't know either well, but of course that is not the correct way to > fix it. The correct way would be to add appropriate GCPRO and UNGCPRO > calls for temporary data structures that should not yet be collected. I suspect this must be done in the coding functions. This call to inhibit_garbage_collection was there about two years ago (1.234 removed it), and it is still present in macmenu.c, which is the only reason the mac port works better. I suspect the w32 port also has this problem, but I can't test that port. I'll work a bit more on this, as a temporary solution I checked in this patch. Jan D.