From: Yuan Fu <casouri@gmail.com>
To: Vincenzo Pupillo <v.pupillo@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: treesit-range-settings with ':local' : I missed something or it's a bug?
Date: Tue, 30 Jan 2024 22:32:47 -0800 [thread overview]
Message-ID: <BE976CE4-FD37-4B41-9F31-F16AE1A3C4A0@gmail.com> (raw)
In-Reply-To: <3273091.aeNJFYEL58@fedora>
> On Jan 29, 2024, at 6:04 AM, Vincenzo Pupillo <v.pupillo@gmail.com> wrote:
>
> Hi Yuan,
> In data domenica 28 gennaio 2024 08:09:02 CET, Yuan Fu ha scritto:
>>
>> Actually, local parsers are not included in the return value of
>> (treesit-parser-list). By default, treesit-parser-list returns all the
>> parsers whose tag is nil, but all the local parsers carry a tag of
>> ‘embedded. To actually return all the parsers in the buffer you need to use
>> (treesit-parser-list nil nil t), ie, pass t to the TAG parameter.
>>
>> I pulled your php-ts-mode_phpdoc.el and played around with it. I found the
>> root cause to be the call to
>>
>> (treesit-parser-create ‘phpdoc)
>>
>> In the major mode body. This creates a global phpdoc parser that fontifies
>> everything in doc face.
>>
>> Removing that, plus the fix for #1 that I just pushed to master, should fix
>> the font-lock problem you are observing.
> It seems to work, but just try to indent the entire buffer, and the problem
> reappears. Before indenting:
> ((#<treesit-parser for html> ((1 . 271))) (#<treesit-parser for css> ((161 .
> 223))) (#<treesit-parser for javascript> ((73 . 138))) (#<treesit-parser for
> php> nil) (#<treesit-parser for phpdoc> ((517 . 621))) (#<treesit-parser for
> phpdoc> ((672 . 810))) (#<treesit-parser for phpdoc> ((939 . 1032)))
> (#<treesit-parser for phpdoc> ((1157 . 1223))))
>
> after indenting the whole buffer:
>
> ((#<treesit-parser for html> ((1 . 271))) (#<treesit-parser for css> ((161 .
> 223))) (#<treesit-parser for javascript> ((73 . 138))) (#<treesit-parser for
> php> nil) (#<treesit-parser for phpdoc> ((517 . 621))) (#<treesit-parser for
> phpdoc> ((672 . 810))) (#<treesit-parser for phpdoc> ((939 . 1032)))
> (#<treesit-parser for phpdoc> ((1157 . 1223))) (#<treesit-parser for phpdoc>
> nil))
>
> As you can see the list of parsers has changed, and the latest one is:
> (#<treesit-parser for phpdoc> nil) .
>
> To reproduce the problem:
> 1. open a php file (for e.g. the php file attached)
> 2. Indent the entire buffer
> 3. add a comment line inside a document block
>
> The attached screenshot shows the result.
That’s due to a bug in treesit--indent-1. I’ve pushed a fix for it to master. It should solve your problem. BTW, you don’t need to call flush-syntax-ppss anymore, we fixed that bug a while back.
Yuan
next prev parent reply other threads:[~2024-01-31 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 11:15 treesit-range-settings with ':local' : I missed something or it's a bug? Vincenzo Pupillo
2024-01-25 12:21 ` Vincenzo Pupillo
2024-01-27 4:32 ` Yuan Fu
2024-01-27 10:23 ` Vincenzo Pupillo
2024-01-28 7:09 ` Yuan Fu
2024-01-29 14:04 ` Vincenzo Pupillo
2024-01-31 6:32 ` Yuan Fu [this message]
2024-01-31 20:05 ` Vincenzo Pupillo
2024-01-31 20:24 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE976CE4-FD37-4B41-9F31-F16AE1A3C4A0@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).