From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: `customize-customized' and mode variable of a minor mode Date: Fri, 6 Apr 2007 11:10:05 -0700 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1175889234 25759 80.91.229.12 (6 Apr 2007 19:53:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2007 19:53:54 +0000 (UTC) To: "Emacs-Devel" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 21:53:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HZstn-00081P-EL for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2007 20:10:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HZsxI-0002cL-LK for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2007 14:14:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HZsxF-0002c7-DC for emacs-devel@gnu.org; Fri, 06 Apr 2007 14:14:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HZsxD-0002bn-33 for emacs-devel@gnu.org; Fri, 06 Apr 2007 14:14:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HZsxC-0002bk-Ps for emacs-devel@gnu.org; Fri, 06 Apr 2007 14:14:30 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HZstg-0004St-LH for emacs-devel@gnu.org; Fri, 06 Apr 2007 14:10:52 -0400 Original-Received: from rgmgw3.us.oracle.com (rgmgw3.us.oracle.com [138.1.186.112]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l36IAVYs013674 for ; Fri, 6 Apr 2007 12:10:31 -0600 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by rgmgw3.us.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l36I6FGo017737 for ; Fri, 6 Apr 2007 12:10:30 -0600 Original-Received: from dhcp-amer-whq-csvpn-gw3-141-144-81-178.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 2594422391175883009; Fri, 06 Apr 2007 11:10:09 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3028 X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69134 Archived-At: `define-minor-mode' defines a defcustom, not a defvar, for the mode variable. That seems like a good thing. However, if the mode has been toggled, then `customize-customized' recognizes this variable's value as having changed. This can be inconvenient. Users should be able to use `customize-customized' to check for variables that they have changed and might want to save. I use `customize-customized' (tweaked so it always returns t) on `kill-emacs-query-functions', for instance, to remind me to save changes. A mode variable change via toggling is not usually a change users want to save. I'm not sure what a good way to avoid this annoyance would be. Perhaps `customize-customized' should reflect a change in a mode variable only if the user changes the value via Customize? That would probably mean making the toggling code tell Customize to ignore the change.