unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: (error "Stack overflow in regexp matcher") and (?)wrong display of regexp in backtrace
Date: Sun, 15 Mar 2020 21:06:46 +0100	[thread overview]
Message-ID: <BDA72D04-82D3-4901-806E-90380105D360@acm.org> (raw)
In-Reply-To: <20200315165715.GD4928@ACM>

15 mars 2020 kl. 17.57 skrev Alan Mackenzie <acm@muc.de>:

> I agree (having tried "\\(?:" in place of "\\("), but why?  What is
> causing the recursion here?  Each of the two groups need only remember
> the latest string matching it.  Surely?  I'd like some insight into
> this, so as to avoid it happening again.

Each time a capture group is entered, the old extent of that group is pushed onto the stack so that it can be reloaded if a match failure occurs and the engine needs to backtrack. This means that removing the unnecessary group is not an asymptotic improvement in space here, but reduces the constant factor so that you can match larger strings. It's still O(N) space, N being the string size.

You could probably rewrite the regexp to improve the constant further by taking advantage of the fact that the [^\\\n\r] branch matches much more often than the other. Something like

(rx (* (seq "\\" anything))
    (* (+ (not (any "\n\r\\")))
       (seq "\\" anything))
    (* (not (any "\n\r\\"))))

which could perhaps be trimmed a bit. In any case, removing unnecessary capture groups everywhere is a cheap and easy improvement to start with. (Another benefit of rx, by the way -- there tends to be a lot fewer of those.)




  reply	other threads:[~2020-03-15 20:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 10:39 (error "Stack overflow in regexp matcher") and (?)wrong display of regexp in backtrace Alan Mackenzie
2020-03-15 12:22 ` Mattias Engdegård
2020-03-15 12:33   ` Mattias Engdegård
2020-03-15 16:57   ` Alan Mackenzie
2020-03-15 20:06     ` Mattias Engdegård [this message]
2020-03-15 14:21 ` Noam Postavsky
2020-03-15 14:56   ` Eli Zaretskii
2020-03-15 16:35 ` Stefan Monnier
2020-03-15 17:32   ` Alan Mackenzie
2020-03-15 17:38     ` Mattias Engdegård
2020-03-15 17:46       ` Eli Zaretskii
2020-03-15 18:02         ` Andreas Schwab
2020-03-16  0:32           ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BDA72D04-82D3-4901-806E-90380105D360@acm.org \
    --to=mattiase@acm.org \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).