From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Thu, 29 Jul 2021 12:59:43 -0400 Message-ID: References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> <834kcetmly.fsf@gnu.org> <831r7itjc8.fsf@gnu.org> <24808548-23F4-4068-877E-37C7190A02B0@gmail.com> <83wnpas1q7.fsf@gnu.org> <83k0l9rvf5.fsf@gnu.org> <83fsvxrszr.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , Stephen Leake , Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 29 19:01:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m99P3-0004o0-FY for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 19:01:01 +0200 Original-Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m99P1-00081Y-CI for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Jul 2021 13:00:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m99Nt-0007ET-OH for emacs-devel@gnu.org; Thu, 29 Jul 2021 12:59:50 -0400 Original-Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:40808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m99Nr-0003GM-Lu; Thu, 29 Jul 2021 12:59:49 -0400 Original-Received: by mail-qk1-x736.google.com with SMTP id z24so6628551qkz.7; Thu, 29 Jul 2021 09:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ygbWtJWt0KE+r5+Y8cZ9VvBqptn5Ije4hvA6YvPUbaE=; b=DqtBhbi3J2+b5g6XhyXbP5I/1Z0Sw0p4uctiXe4dtiLYhvH1bKhqS8EThxUXCD6sD6 1d4hw73dSgWrBjREY079Bvq1HoqE0Nfat3h5OfomOYubKGeOPEroHAmRUd64lInxphG9 hU9K36ltW2PKEa/vPIX8NiY0nDV+ShuUCiEmB2dfmfzm3VNT0ItSZLrdB3tolsp7pHA1 JQyYr1lXaAAMH1lck2iEukUd3YFDo9xLAS1HedaYA/jn2Fd8U+680Py5sMVdZgxCiOMr 8e1M0wt/oX8oct0EmQQGLjVibCK2R8BsbCNsNKnsUHoBs+rQZpHFAJ74WewpCLuU9g+T QCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ygbWtJWt0KE+r5+Y8cZ9VvBqptn5Ije4hvA6YvPUbaE=; b=XdPTvY7Uy8X88u/mO91S5dCV8RKOtedx25jq7IJXvE4ydRtq2/232ucWbv+VTEmGwB fppPXVnmd2JluidIVe+qmot2XDBYRYjSOO0FGwQepSIRBlRJxejKMBgnXVSeavwrbg7p VLM+hJ1glj0ZRgFQ/eIX3AhHojihCaow9CMovGi/JUYhLTWzgLAFCDT6wmRk1oaq65bI 2B+PISQ+apZXeWrjrFR+S0yQfo3qmDPNfFFKf5zoHewoz+FL0s/QzKYRqGu3n4Z6IJEQ OdeOlE0v3x42L7v/PtpieHVXFoW3uLR6Ct1f4zqH2+K7qUd7W4J7b/Zc9H0FXj3vYfkE lYLg== X-Gm-Message-State: AOAM530XHZo3+s0rYj+YZB5fIGTwWsJMZX6NVLOAVBOl7Kzjefji0ks/ SywOfD2heyZ80Abp/cDq+a7GmTStKQZtQA== X-Google-Smtp-Source: ABdhPJzh0NZDXu6kqzrf+DANcnU+rudstDlNKJ3J/pWQMX7TwXJIv4FRr3JMgtHtYIPPt7kwtpVfIA== X-Received: by 2002:a37:e4f:: with SMTP id 76mr6138645qko.44.1627577985834; Thu, 29 Jul 2021 09:59:45 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com (2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com. [2603:7080:302:635e:540d:2222:3fe9:1314]) by smtp.gmail.com with ESMTPSA id s14sm2138203qke.1.2021.07.29.09.59.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 09:59:45 -0700 (PDT) In-Reply-To: <83fsvxrszr.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::736; envelope-from=casouri@gmail.com; helo=mail-qk1-x736.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271794 Archived-At: > On Jul 29, 2021, at 12:21 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 29 Jul 2021 11:57:56 -0400 >> Cc: Stephen Leake , >> Cl=C3=A9ment Pit-Claudel , >> monnier@iro.umontreal.ca, >> emacs-devel@gnu.org >>=20 >>>> Anyway, I found a way that avoids this issue: the bounds of = tree-sitter=E2=80=99s visible region never changes, and the next time = when lisp narrows to a different region, we update tree-sitter=E2=80=99s = bound to match that of the narrowing. Here is the latest patch. If the = code is not entirely straightforward, I=E2=80=99m happy to add more = comment to explain it. >>>=20 >>> I'm not sure we should do this, because it means we second-guess = what >>> the Lisp program calling TS intends to do. Why should we do that, >>> instead of leaving it to the Lisp program to DTRT? And what happens >>> if our guess is wrong? >>=20 >> I don=E2=80=99t think the current implementation guesses anything. = Let me turn around and ask you what is TRT: if the buffer is xxxAAAxxx, = and lisp narrows to AAA and creates a parser, parser sees AAA; now = widen, user inserts BBB in front of AAA, what do we tell tree-sitter? = Nothing changed, or BBB inserted at the beginning? >=20 > Neither. We should tell TS that instead of AAA there's now > xxxBBBAAAxxx, because the narrowing was removed. This is the common usage that I imagined: Narrow Calls tree-sitter (for fontification etc) Widen Users edit the buffer narrow Calls tree-sitter (for fontification etc) Widen Ideally, tree-sitter only sees the narrowed region because everytime it = is called, the buffer is narrowed. However, tree-sitter doesn=E2=80=99t = work that way, it needs to be updated when user edits the buffer, when = the buffer is widened. If your goal is give lisp control of what = tree-sitter sees, we can=E2=80=99t just give tree-sitter the whole = buffer whenever the user makes some change. >=20 >> To where should lisp narrow? BBBAAA, or AAA, or BBB? >=20 > It's the question for the Lisp program, not for the low-level code > which we are discussing. >=20 > Anyway, you are once again bothered by a scenario that should not > happen at all: a Lisp program should not call TS first with, then > without narrowing (or the other way around). I don't see why such > situation should happen, and if they do, the Lisp programs which need > them will have to figure out what to do and how. Even if lisp always call tree-sitter with narrowing, we still need to = update tree-sitter when the buffer is widened. Does that make sense? Yuan