unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Fri, 6 Dec 2024 17:12:38 -0800	[thread overview]
Message-ID: <BC1C169B-B537-4F24-92C2-68296EFF47D3@gmail.com> (raw)
In-Reply-To: <86ser2y5e1.fsf@gnu.org>



> On Dec 4, 2024, at 11:07 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Wed, 4 Dec 2024 22:25:33 -0800
>> Cc: emacs-devel@gnu.org
>> 
>>>> If we use eval-when-compile, we don’t need to write declare-function forms in c-ts-mode.el anymore, because treesit.el has declare-function forms for all treesit.c functions.
>>> 
>>> That's what I don't understand: how will eval-when-compile which loads
>>> treesit.el be different from (require 'treesit) we already have in
>>> c-ts-mode?  Don't they both load treesit.el?
>> 
>> I maybe wrong here, but I thought if you don’t use eval-when-compile, simply byte-compiling c-ts-mode.el wouldn’t load treesit.el?
> 
> Yes, it would.  You can clearly see this in a debugger if you put a
> breakpoint in Fload and then byte-compile c-ts-mode.el.

Does that mean declare-function forms only affect the file it’s in? Because if treesit.el has declare-function forms for all the treesit.c functions, and c-ts-mode.el requires treesit.el, why do we need to have declare-function forms in c-ts-mode.el?

Yuan


  reply	other threads:[~2024-12-07  1:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03  8:30 ` Andrea Corallo
2024-12-04 18:21   ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19   ` Yuan Fu
2024-12-04 18:57     ` Eli Zaretskii
2024-12-05  6:25       ` Yuan Fu
2024-12-05  7:07         ` Eli Zaretskii
2024-12-07  1:12           ` Yuan Fu [this message]
2024-12-07  7:51             ` Eli Zaretskii
2024-12-07 13:47               ` Stefan Monnier
2024-12-08  6:39                 ` Yuan Fu
2024-12-08  7:20                   ` Eli Zaretskii
2024-12-11 23:28                     ` Andrea Corallo
2024-12-08 15:27                   ` Stefan Monnier
2024-12-09  1:37                     ` Yuan Fu
2024-12-09  2:40                       ` Stefan Monnier
2024-12-11  1:57                         ` Dmitry Gutov
2024-12-08 16:01     ` Dmitry Gutov
2024-12-11 23:38       ` Andrea Corallo
2024-12-12  0:23         ` Dmitry Gutov
2024-12-12  6:05           ` Yuan Fu
2024-12-12  6:43             ` Eli Zaretskii
2024-12-12  6:19           ` Eli Zaretskii
2024-12-12  6:13         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BC1C169B-B537-4F24-92C2-68296EFF47D3@gmail.com \
    --to=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).