From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jan Rehders Newsgroups: gmane.emacs.devel Subject: Re: Adding new package org-menu to nongnu elpa Date: Sat, 16 Nov 2024 01:20:15 +0900 Message-ID: References: <87jzd4ehkd.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 16 08:13:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCCzq-0005CB-Gl for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Nov 2024 08:13:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCCz3-0007Kg-P1; Sat, 16 Nov 2024 02:12:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBz3z-0002ZN-10 for emacs-devel@gnu.org; Fri, 15 Nov 2024 11:20:51 -0500 Original-Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1tBz3x-0006wY-3T for emacs-devel@gnu.org; Fri, 15 Nov 2024 11:20:50 -0500 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Xqj1C0xRlz9vDS; Fri, 15 Nov 2024 17:20:31 +0100 (CET) In-Reply-To: <87jzd4ehkd.fsf@posteo.net> Received-SPF: permerror client-ip=2001:67c:2050:0:465::102; envelope-from=jan@sheijk.net; helo=mout-p-102.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 16 Nov 2024 02:12:37 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325470 Archived-At: Thanks for the feedback. Applied them. Some comments: > + (_ (insert (format "unknown snippet type %s" snippet-id))))) ;or = use `pcase-exhaustive'? Throwing an error here now to keep the info about what snippet type was = not found > +;; You are require'ing yasnippet anyway, so there is no need to mess = with autoloads yasnippet should only be required dynamically if it is selected so the = plugin can work without it being installed > (defun org-menu-toggle-nbspace () > "Will remove non-breaking space before/after point or insert it if = none found." > + ;; ^ > + ;; Non-breaking or zero-width space? \u200b is = zero-width (used below) Yes that should have been zero-width space. Fixed > +;; Can you explain why you are copying code org-colview.el? It is = not > +;; clear to me why you don't try to call it directly. This code used to be in lambdas and has since been moved into top-level = functions. Calling them now I=E2=80=99ve also changed the calls to deprecated functions you pointed = out. This might break with older Emacs versions but those are supported = as a best effort, only so let=E2=80=99s see if this fails for anyone or = if compat.el handles this Thanks!