* Patch to pcomplete to make it work with shell-mode again
@ 2009-07-09 8:27 Herbert Euler
2009-07-12 16:20 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Euler @ 2009-07-09 8:27 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
After the new function `shell-dynamic-complete-filename' was added, pcomplete was broken.
The attached patch fixes it.
Regards,
Guanpeng Xu
_________________________________________________________________
Windows Live™: Keep your life in sync. Check it out!
http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_allup_explore_012009
[-- Attachment #1.2: Type: text/html, Size: 514 bytes --]
[-- Attachment #2: pcomplete.patch --]
[-- Type: application/octet-stream, Size: 1149 bytes --]
Index: pcomplete.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/pcomplete.el,v
retrieving revision 1.39
diff -c -F '^(defun' -r1.39 pcomplete.el
*** pcomplete.el 5 Jan 2009 03:19:38 -0000 1.39
--- pcomplete.el 9 Jul 2009 08:26:38 -0000
*************** (defun pcomplete-comint-setup (completef
*** 590,597 ****
(set (make-local-variable 'pcomplete-parse-arguments-function)
'pcomplete-parse-comint-arguments)
(make-local-variable completef-sym)
! (let ((elem (memq 'comint-dynamic-complete-filename
! (symbol-value completef-sym))))
(if elem
(setcar elem 'pcomplete)
(add-to-list completef-sym 'pcomplete))))
--- 590,599 ----
(set (make-local-variable 'pcomplete-parse-arguments-function)
'pcomplete-parse-comint-arguments)
(make-local-variable completef-sym)
! (let ((elem (or (memq 'comint-dynamic-complete-filename
! (symbol-value completef-sym))
! (memq 'shell-dynamic-complete-filename
! (symbol-value completef-sym)))))
(if elem
(setcar elem 'pcomplete)
(add-to-list completef-sym 'pcomplete))))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch to pcomplete to make it work with shell-mode again
2009-07-09 8:27 Patch to pcomplete to make it work with shell-mode again Herbert Euler
@ 2009-07-12 16:20 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2009-07-12 16:20 UTC (permalink / raw)
To: Herbert Euler; +Cc: emacs-devel
Herbert Euler <herberteuler@hotmail.com> writes:
> After the new function `shell-dynamic-complete-filename' was added,
> pcomplete was broken. The attached patch fixes it.
Checked in, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-12 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-09 8:27 Patch to pcomplete to make it work with shell-mode again Herbert Euler
2009-07-12 16:20 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).